You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/12/16 11:07:29 UTC
[GitHub] [cordova-cli] erisu opened a new pull request #570: feat: rebuilt package-lock w/ v2
erisu opened a new pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570
### Motivation and Context
Prepare for Cordova CLI 11 Release
### Description
Rebuilt the `package-lock.json` file with v2
### Testing
- GH Actions
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] timbru31 commented on pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570#issuecomment-995691494
Does this have any implications for Node.js versions that still use v1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] codecov-commenter edited a comment on pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570#issuecomment-995691276
# [Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#570](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b49f1cc) into [master](https://codecov.io/gh/apache/cordova-cli/commit/b164b330c5cf05be11ad15bf1c8d1da11588d961?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b164b33) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 70.40% 70.40%
=======================================
Files 4 4
Lines 321 321
=======================================
Hits 226 226
Misses 95 95
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b164b33...b49f1cc](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] erisu commented on pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570#issuecomment-995697177
Some points about the lock version is that it is an NPM thing, not Node.JS.
People could have installed an older Node.js and installed the latest NPM with `npm i -g npm@latest`.
The package-lock is a development file and never bundled with the production release package.
About the version support, https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#lockfileversion
> Note that the file format changed significantly in npm v7 to track information that would have otherwise required looking in node_modules or the npm registry. Lockfiles generated by npm v7 will contain lockfileVersion: 2.
>
> No version provided: an "ancient" shrinkwrap file from a version of npm prior to npm v5.
>
> 1: The lockfile version used by npm v5 and v6.
> 2: The lockfile version used by npm v7, which is backwards compatible to v1 lockfiles.
> 3: The lockfile version used by npm v7, without backwards compatibility affordances. This is used for the hidden lockfile at node_modules/.package-lock.json, and will likely be used in a future version of npm, once support for npm v6 is no longer relevant.
>
> npm will always attempt to get whatever data it can out of a lockfile, even if it is not a version that it was designed to support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] erisu commented on pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570#issuecomment-995699307
@timbru31, I hope the above explains enough.
But, here is also the parent ticket to direct this change: https://github.com/apache/cordova/issues/300
This was also discussed in the mailing list and the link is in the above ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] codecov-commenter commented on pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570#issuecomment-995691276
# [Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#570](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8eadc0b) into [master](https://codecov.io/gh/apache/cordova-cli/commit/09b6cebd5fb5498d07536835cfb8550df2c18bc4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09b6ceb) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 70.40% 70.40%
=======================================
Files 4 4
Lines 321 321
=======================================
Hits 226 226
Misses 95 95
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [09b6ceb...8eadc0b](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] codecov-commenter edited a comment on pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570#issuecomment-995691276
# [Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#570](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8eadc0b) into [master](https://codecov.io/gh/apache/cordova-cli/commit/b164b330c5cf05be11ad15bf1c8d1da11588d961?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b164b33) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 8eadc0b differs from pull request most recent head b49f1cc. Consider uploading reports for the commit b49f1cc to get more accurate results
[](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 70.40% 70.40%
=======================================
Files 4 4
Lines 321 321
=======================================
Hits 226 226
Misses 95 95
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b164b33...b49f1cc](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] codecov-commenter edited a comment on pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570#issuecomment-995691276
# [Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#570](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8eadc0b) into [master](https://codecov.io/gh/apache/cordova-cli/commit/09b6cebd5fb5498d07536835cfb8550df2c18bc4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09b6ceb) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 70.40% 70.40%
=======================================
Files 4 4
Lines 321 321
=======================================
Hits 226 226
Misses 95 95
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [09b6ceb...8eadc0b](https://codecov.io/gh/apache/cordova-cli/pull/570?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] erisu edited a comment on pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570#issuecomment-995697177
Some points about the package-lock is that is apart of NPM's structure, not Node.js.
People could have installed an older Node.js and installed the latest NPM with `npm i -g npm@latest`.
The package-lock is a development file and never bundled with the production release package.
About the version support, https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#lockfileversion
> Note that the file format changed significantly in npm v7 to track information that would have otherwise required looking in node_modules or the npm registry. Lockfiles generated by npm v7 will contain lockfileVersion: 2.
>
> No version provided: an "ancient" shrinkwrap file from a version of npm prior to npm v5.
>
> 1: The lockfile version used by npm v5 and v6.
> 2: The lockfile version used by npm v7, which is backwards compatible to v1 lockfiles.
> 3: The lockfile version used by npm v7, without backwards compatibility affordances. This is used for the hidden lockfile at node_modules/.package-lock.json, and will likely be used in a future version of npm, once support for npm v6 is no longer relevant.
>
> npm will always attempt to get whatever data it can out of a lockfile, even if it is not a version that it was designed to support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] erisu merged pull request #570: feat: rebuilt package-lock w/ v2
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #570:
URL: https://github.com/apache/cordova-cli/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org