You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/10 19:31:52 UTC
[GitHub] [airflow] itaymaslo opened a new pull request, #28839: Fix taskflow.rst duplicated "or"
itaymaslo opened a new pull request, #28839:
URL: https://github.com/apache/airflow/pull/28839
"... Docker container (since version 2.2.0) **or or** ExternalPythonOperator ..." -> "... Docker container (since version 2.2.0) **or** ExternalPythonOperator ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28839: Fix taskflow.rst duplicated "or"
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28839:
URL: https://github.com/apache/airflow/pull/28839#issuecomment-1379332356
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28839: Fix taskflow.rst duplicated "or"
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28839:
URL: https://github.com/apache/airflow/pull/28839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #28839: Fix taskflow.rst duplicated "or"
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #28839:
URL: https://github.com/apache/airflow/pull/28839#discussion_r1066275497
##########
docs/apache-airflow/tutorial/taskflow.rst:
##########
@@ -234,8 +234,7 @@ Using the TaskFlow API with complex/conflicting Python dependencies
-------------------------------------------------------------------
If you have tasks that require complex or conflicting requirements then you will have the ability to use the
-TaskFlow API with either Python virtual environment (since 2.0.2), Docker container (since version 2.2.0) or
-or ExternalPythonOperator or KubernetesPodOperator (since 2.4.0).
+TaskFlow API with either Python virtual environment (since 2.0.2), Docker container (since version 2.2.0) or ExternalPythonOperator or KubernetesPodOperator (since 2.4.0).
Review Comment:
```suggestion
TaskFlow API with either Python virtual environment (since 2.0.2), Docker container (since 2.2.0), ExternalPythonOperator (since 2.4.0) or KubernetesPodOperator (since 2.4.0).
```
Since we are fixing this section up already, let's simplify this even more as the "or a or b" is a little confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28839: Fix taskflow.rst duplicated "or"
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28839:
URL: https://github.com/apache/airflow/pull/28839#issuecomment-1377748572
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org