[GitHub] [flink] walterddr commented on a change in pull request #11220: [FLINK-16249][python][ml] Add interfaces for Params, ParamInfo and WithParams

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #11220: [FLINK-16249][python][ml] Add interfaces for Params, ParamInfo and WithParams
URL: https://github.com/apache/flink/pull/11220#discussion_r385243100
 
 

 ##########
 File path: flink-python/setup.py
 ##########
 @@ -224,7 +224,7 @@ def remove_if_exists(file_path):
         author_email='dev@flink.apache.org',
         python_requires='>=3.5',
         install_requires=['py4j==0.10.8.1', 'python-dateutil==2.8.0', 'apache-beam==2.19.0',
-                          'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1'],
+                          'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1', 'jsonpickle==1.2'],
 
 Review comment:
   Based on a quick look at the python [packaging doc](https://packaging.python.org/discussions/install-requires-vs-requirements/#install-requires-vs-requirements-files) seems like `install_requires` refers to the bare minimum that is needed for it to function. Does `jsonpickle` satisfies that requirement? 
   
   Making all the dependencies as required is one quick solution. but I am afraid that this might lead to issues managing dependencies going forward?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services