You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/05 08:14:29 UTC
[GitHub] [spark] beliefer commented on a diff in pull request #37047: [SPARK-39627][SQL] DS V2 pushdown should unify the compile API
beliefer commented on code in PR #37047:
URL: https://github.com/apache/spark/pull/37047#discussion_r913514346
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala:
##########
@@ -31,34 +33,43 @@ private object DB2Dialect extends JdbcDialect {
url.toLowerCase(Locale.ROOT).startsWith("jdbc:db2")
// See https://www.ibm.com/docs/en/db2/11.5?topic=functions-aggregate
- override def compileAggregate(aggFunction: AggregateFunc): Option[String] = {
- super.compileAggregate(aggFunction).orElse(
- aggFunction match {
- case f: GeneralAggregateFunc if f.name() == "VAR_POP" =>
- assert(f.children().length == 1)
- val distinct = if (f.isDistinct) "DISTINCT " else ""
- Some(s"VARIANCE($distinct${f.children().head})")
- case f: GeneralAggregateFunc if f.name() == "VAR_SAMP" =>
- assert(f.children().length == 1)
- val distinct = if (f.isDistinct) "DISTINCT " else ""
- Some(s"VARIANCE_SAMP($distinct${f.children().head})")
- case f: GeneralAggregateFunc if f.name() == "STDDEV_POP" =>
- assert(f.children().length == 1)
- val distinct = if (f.isDistinct) "DISTINCT " else ""
- Some(s"STDDEV($distinct${f.children().head})")
- case f: GeneralAggregateFunc if f.name() == "STDDEV_SAMP" =>
- assert(f.children().length == 1)
- val distinct = if (f.isDistinct) "DISTINCT " else ""
- Some(s"STDDEV_SAMP($distinct${f.children().head})")
- case f: GeneralAggregateFunc if f.name() == "COVAR_POP" && f.isDistinct == false =>
- assert(f.children().length == 2)
- Some(s"COVARIANCE(${f.children().head}, ${f.children().last})")
- case f: GeneralAggregateFunc if f.name() == "COVAR_SAMP" && f.isDistinct == false =>
- assert(f.children().length == 2)
- Some(s"COVARIANCE_SAMP(${f.children().head}, ${f.children().last})")
- case _ => None
+ private val supportedAggregateFunctions =
+ Set("VAR_POP", "VAR_SAMP", "STDDEV_POP", "STDDEV_SAMP", "COVAR_POP", "COVAR_SAMP")
+ private val supportedFunctions = supportedAggregateFunctions
+
+ override def isSupportedFunction(funcName: String): Boolean =
+ supportedFunctions.contains(funcName)
+
+ class DB2SQLBuilder extends JDBCSQLBuilder {
Review Comment:
`JDBCSQLBuilder` already check `supportedFunctions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org