[GitHub] [arrow] mbrobbel edited a comment on pull request #11937: ARROW-1569: [C++] Kernel functions for determining monotonicity (ascending or descending) for well-ordered types

[GitBox <gi...@apache.org>]

mbrobbel edited a comment on pull request #11937:
URL: https://github.com/apache/arrow/pull/11937#issuecomment-996683557


   >     * `IsMonotonic` needs to be consistent with corresponding [sorting functions](https://arrow.apache.org/docs/cpp/compute.html#sorts-and-partitions), such that `IsMonotonic(input) == (Sort(input) == input)`.
   
   I agree.
   
   >     * Currently `IsMonotonic` outputs a struct describing the monotonic properties of the data. What your thoughts on having a convenience wrapper function that receives `FunctionOptions` with a single requested monotonic behavior? For example, `IsMonotonic(input, MonotonicOptions.StrictlyIncreasing)`. This would provide a more readable API for client code and bypass the need to unpack the `StructScalar` output to check the corresponding monotonic behavior of interest.
   
   I initially set it up like that but @bkietz suggested to output a struct scalar instead (like the min/max kernel).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org