[GitHub] [incubator-nuttx] mlyszczek commented on a diff in pull request #6413: stm32wl5: add gpio exti support

[GitBox <gi...@apache.org>]

mlyszczek commented on code in PR #6413:
URL: https://github.com/apache/incubator-nuttx/pull/6413#discussion_r895377305


##########
arch/arm/src/stm32wl5/stm32wl5_exti_gpio.c:
##########
@@ -121,9 +253,60 @@ static int stm32wl5_exti0_15_isr(int irq, void *context, FAR void *arg)
 int stm32wl5_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
                          bool event, xcpt_t func, void *arg)
 {
+  struct gpio_callback_s *shared_cbs;
   uint32_t pin = pinset & GPIO_PIN_MASK;
-  uint32_t exti = 1 << pin;
-  int      irq = STM32WL5_IRQ_EXTI0 + pin;
+  uint32_t exti = (1 << pin);

Review Comment:
   Ahh, right, I've changed the another "1 << pin" to "(1 << pin)" instead the other way around xD



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org