You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/07/02 13:15:57 UTC

[GitHub] [buildstream] abderrahim opened a new pull request, #1670: _platform: add RISC-V to the list of supported platforms

abderrahim opened a new pull request, #1670:
URL: https://github.com/apache/buildstream/pull/1670

   See https://github.com/bazelbuild/remote-apis/pull/227


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] juergbi merged pull request #1670: _platform: add RISC-V to the list of supported platforms

Posted by GitBox <gi...@apache.org>.
juergbi merged PR #1670:
URL: https://github.com/apache/buildstream/pull/1670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] juergbi commented on a diff in pull request #1670: _platform: add RISC-V to the list of supported platforms

Posted by GitBox <gi...@apache.org>.
juergbi commented on code in PR #1670:
URL: https://github.com/apache/buildstream/pull/1670#discussion_r913076725


##########
src/buildstream/_platform/platform.py:
##########
@@ -112,6 +112,10 @@ def canonicalize_arch(arch):
             "powerpc64le": "power-isa-le",  # Used in GCC/LLVM
             "ppc64": "power-isa-be",
             "ppc64le": "power-isa-le",
+            "rv32g": "rv32g",
+            "rv64g": "rv64g",
+            "riscv32": "rv32g",
+            "riscv64": "rv64g",

Review Comment:
   Let's swap these around to keep the dict sorted by key.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org