You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/25 17:23:18 UTC

[GitHub] [airflow] gmsantos opened a new pull request, #27270: Remove short form of --upgrade-on-failure

gmsantos opened a new pull request, #27270:
URL: https://github.com/apache/airflow/pull/27270

   The -u option is defined in --upgrade-to-newer-dependencies option too
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #27270: Remove short form of --upgrade-on-failure

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27270:
URL: https://github.com/apache/airflow/pull/27270#issuecomment-1292728805

   Now-> I resolved conflicts in https://github.com/apache/airflow/pull/27191 after merging it ... Good revires there are welcome so that I can merge it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] uranusjr commented on pull request #27270: Remove short form of --upgrade-on-failure

Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #27270:
URL: https://github.com/apache/airflow/pull/27270#issuecomment-1291730999

   Awesome, so this should be ready when CI passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] gmsantos commented on pull request #27270: Remove short form of --upgrade-on-failure

Posted by GitBox <gi...@apache.org>.
gmsantos commented on PR #27270:
URL: https://github.com/apache/airflow/pull/27270#issuecomment-1290895911

   Before:
   
   ![image](https://user-images.githubusercontent.com/1991286/197841236-364dab0c-04a9-4c6c-a97f-da600062eee7.png)
   
   After:
   
   ![image](https://user-images.githubusercontent.com/1991286/197841318-35407596-75e2-4093-b6d2-3f200f0deec3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] uranusjr commented on pull request #27270: Remove short form of --upgrade-on-failure

Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #27270:
URL: https://github.com/apache/airflow/pull/27270#issuecomment-1291558264

   CI failure is unrelated (see #27287). Does `-u` work for `--upgrade-to-newer-dependencies` _before_ this change? Maybe we should remove that as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #27270: Remove short form of --upgrade-on-failure

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27270:
URL: https://github.com/apache/airflow/pull/27270


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] gmsantos commented on pull request #27270: Remove short form of --upgrade-on-failure

Posted by GitBox <gi...@apache.org>.
gmsantos commented on PR #27270:
URL: https://github.com/apache/airflow/pull/27270#issuecomment-1291618260

   > Does -u work for --upgrade-to-newer-dependencies before this change?
   
   By git blame, the short form for this option was added 6 months ago on breeze, and `--upgrade-on-failure` was added 2 months back. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org