You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/05 16:30:36 UTC

[GitHub] [nifi] ChrisSamo632 commented on pull request #6544: NIFI-9398 add verification to ElasticSearchClientService (with integration tests) and Elasticsearch REST API processors

ChrisSamo632 commented on PR #6544:
URL: https://github.com/apache/nifi/pull/6544#issuecomment-1304581690

   > @ChrisSamo632 see feedback above. When I ran your branch on the command line, I got a bunch of NoClassDef errors because testcontainers has an explicit scope of `test` set in the root pom. `mvn dependency:tree` was showing that testcontainers was not coming through as a transitive dependency via the test utils jar.
   
   @MikeThomsen thanks for the review, I think I've addressed all your comments now (I unresolved those in the discussion that I believed needed changes to be made, that way I/you can see what needs re-reviewing).
   
   Also updated the 7.x and 8.x image versions to the latest available (new releases from Elastic recently).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org