You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Talluri (Code Review)" <ge...@cloudera.org> on 2017/08/02 20:01:30 UTC
[kudu-CR] KUDU-2039 Fix the table count in the /tables page of master webUI
Abhishek Talluri has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7568
Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI
......................................................................
KUDU-2039 Fix the table count in the /tables page of master webUI
The table count that was displayed on the webUI does not eliminate
the ones that are deleted. Added a check to see if the table's state
is running and then updated the count.
Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7568/1
--
To view, visit http://gerrit.cloudera.org:8080/7568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Abhishek Talluri <ab...@gmail.com>
[kudu-CR] KUDU-2039 Fix the table count in the /tables page of master webUI
Posted by "Abhishek Talluri (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7568
to look at the new patch set (#3).
Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI
......................................................................
KUDU-2039 Fix the table count in the /tables page of master webUI
The table count that was displayed on the webUI does not eliminate
the ones that are deleted. Added a check to see if the table's state
is running and then updated the count.
Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7568/3
--
To view, visit http://gerrit.cloudera.org:8080/7568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Abhishek Talluri <ab...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2039 Fix the table count in the /tables page of master webUI
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7568/1/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
Line 139:
Nit: leading whitespace here, please trim.
Line 143: TableMetadataLock l(table.get(), TableMetadataLock::READ);
We're already looping over the tables and locking them on L152-164. Could you reuse that loop to compute the table count?
Line 150:
Nit: leading whitespace here, please trim.
--
To view, visit http://gerrit.cloudera.org:8080/7568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Abhishek Talluri <ab...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2039 Fix the table count in the /tables page of master webUI
Posted by "Abhishek Talluri (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7568
to look at the new patch set (#2).
Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI
......................................................................
KUDU-2039 Fix the table count in the /tables page of master webUI
The table count that was displayed on the webUI does not eliminate
the ones that are deleted. Added a check to see if the table's state
is running and then updated the count.
Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/7568/2
--
To view, visit http://gerrit.cloudera.org:8080/7568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Abhishek Talluri <ab...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2039 Fix the table count in the /tables page of master webUI
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI
......................................................................
KUDU-2039 Fix the table count in the /tables page of master webUI
The table count that was displayed on the webUI does not eliminate
the ones that are deleted. Added a check to see if the table's state
is running and then updated the count.
Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
Reviewed-on: http://gerrit.cloudera.org:8080/7568
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Abhishek Talluri <ab...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2039 Fix the table count in the /tables page of master webUI
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI
......................................................................
Patch Set 3: Code-Review+2
Thanks, looks good!
--
To view, visit http://gerrit.cloudera.org:8080/7568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Abhishek Talluri <ab...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] KUDU-2039 Fix the table count in the /tables page of master webUI
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI
......................................................................
Patch Set 2:
(1 comment)
LINT build failed due to the lack of spaces between 'else' and '{' and '}'; if you remove the 'else' altogether (as per the Tidy Bot suggestion) you won't have that problem.
http://gerrit.cloudera.org:8080/#/c/7568/2/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
Line 139: int table_count = 0;
Nit: mind renaming this so it's clear that it only accounts for running tables? Maybe 'num_running_tables'.
--
To view, visit http://gerrit.cloudera.org:8080/7568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Abhishek Talluri <ab...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes