[GitHub] [flink] xuefuz commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…

[GitBox <gi...@apache.org>]

xuefuz commented on a change in pull request #8480: [FLINK-12552][table] Combine HiveCatalog and GenericHiveMetastoreCat…
URL: https://github.com/apache/flink/pull/8480#discussion_r285773385
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/AbstractCatalogTable.java
 ##########
 @@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.catalog;
+
+import org.apache.flink.table.api.TableSchema;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
+/**
+ * An abstract catalog table.
+ */
+public abstract class AbstractCatalogTable implements CatalogTable {
+	// Schema of the table (column names and types)
+	private final TableSchema tableSchema;
+	// Partition keys if this is a partitioned table. It's an empty set if the table is not partitioned
+	private final List<String> partitionKeys;
+	// Properties of the table
+	private final Map<String, String> properties;
+	// Comment of the table
+	private final String comment;
+
+	public AbstractCatalogTable(
+		TableSchema tableSchema,
+		Map<String, String> properties,
+		String comment) {
+		this(tableSchema, new ArrayList<>(), properties, comment);
+	}
+
+	public AbstractCatalogTable(
+			TableSchema tableSchema,
+			List<String> partitionKeys,
+			Map<String, String> properties,
+			String comment) {
+		this.tableSchema = checkNotNull(tableSchema, "tableSchema cannot be null");
+		this.partitionKeys = checkNotNull(partitionKeys, "partitionKeys cannot be null");
+		this.properties = checkNotNull(properties, "properties cannot be null");
+		this.comment = comment;
+	}
+
+	@Override
+	public boolean isPartitioned() {
+		return !partitionKeys.isEmpty();
+	}
+
+	@Override
+	public List<String> getPartitionKeys() {
+		return partitionKeys;
+	}
+
+	@Override
+	public Map<String, String> getProperties() {
+		return properties;
+	}
+
+	@Override
+	public TableSchema getSchema() {
+		return this.tableSchema;
 
 Review comment:
   This is not necessarily introduced by this PR. AbstractXXX classes are mostly extracted from original concrete classes. Nevertheless. I make the changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services