You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by sethah <gi...@git.apache.org> on 2016/10/12 14:56:19 UTC

[GitHub] spark pull request #15406: [Spark-17745][ml][PySpark] update NB python api -...

Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15406#discussion_r83023875
  
    --- Diff: python/pyspark/ml/classification.py ---
    @@ -1032,6 +1032,16 @@ class NaiveBayes(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, H
         >>> result = model3.transform(test0).head()
         >>> result.prediction
         0.0
    +    >>> dfWithWeight = spark.createDataFrame([
    --- End diff --
    
    Sorry for the confusion, I was thinking we could just add weights to the existing example. I don't think an entirely separate example is necessary. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org