You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/10/09 01:03:49 UTC

[PR] chore(deps): upgrade Astryx to 0.6.6 [maka]

Astro-Han opened a new pull request, #6012:
URL: https://github.com/apache/maka/pull/6012

   ## Summary
   
   Upgrade `@astryxdesign/core`, `@astryxdesign/theme-neutral`, and `@astryxdesign/cli` together from 0.6.3 to 0.6.6. The released fixes improve Chat input sizing, Markdown parsing and table layout, menu interactions, and anchored-layer placement without changing Maka's visual direction.
   
   - Rebase the existing core patch onto the published 0.6.6 package. Remove the inline-token alignment patch now shipped upstream, while preserving host-owned transcript scrolling, IME caret placement, streaming presentation, lazy tool details, busy states, touch-trigger stability, compositor-driven Spinner animation, and dialog-safe Toast placement.
   - Keep the new upstream tool-call focus treatment, menu link/ref support, Markdown implementation, and layer context/inset handling when resolving overlapping patch hunks.
   - Regenerate the theme artifacts, Astryx surface inventory version, and license notices. The generated theme now preserves inherited icon artwork when composing the theme's icon registry.
   - Supply the real LinkeDOM `Element`, `HTMLElement`, and `Node` constructors in four existing UI test harnesses. Astryx's delegated press controller now uses these standard DOM APIs; no production behavior or test assertions are bypassed.
   
   Upstream: [0.6.6 release notes](https://github.com/facebook/astryx/releases/tag/v0.6.6).
   
   ## Verification
   
   - Clean `npm ci`: passes; patch-package applies `@astryxdesign/core@0.6.6` successfully.
   - Dependency workspace builds and `npm --workspace @maka/desktop run build`: pass.
   - `npm --workspace @maka/desktop run typecheck`: passes, including renderer and Storybook types.
   - UI workspace suite with `--test-concurrency=4`: **713 passed**, including a second run after the clean install.
   - Desktop workspace suite with `--test-concurrency=4`: **3280 passed**.
   - `npm run format`, `npm run lint`, and `git diff --check`: pass.
   - Generated-theme freshness, Astryx surface inventory, and third-party notice checks: pass.
   - Built Storybook separately from the base `main` commit (`6d53ca8e9`) and this branch. Inspected live DOM, computed styles, geometry, and JavaScript errors through CDP, driving interactions by DOM event dispatch. Verified the new Markdown cell padding (8px on every edge), a settings selector contained within the viewport, and Escape dismissal restoring focus for both the selector and a sidebar task menu. These interaction checks report no JavaScript exceptions or failed resources.
   - No whole-repository test run or local Electron E2E run; CI remains responsible for those required lanes.
   
   The comparisons use the same General settings, rich Markdown, and collapsed tool-activity stories at the same width. The settings viewport is extended equally in both builds to include the complete internal scrolling page. Settings and collapsed activity remain visually unchanged; Markdown adopts upstream table spacing and column sizing.
   
   ![Astryx light-mode before and after](https://github.com/user-attachments/assets/c8733249-bfc0-45ad-966b-24364d352649)
   
   ![Astryx dark-mode before and after](https://github.com/user-attachments/assets/4ff5fa91-4a09-42b7-be5e-b1e847f1eb59)
   
   ## Compatibility
   
   This is a stable patch-series upgrade, not a product UI redesign. Existing deprecated upstream prop names remain supported. No Runtime Host protocol, persisted state, or product theme tokens change. The retained core patch is still required; this PR does not claim that the open IME, touch-trigger, Spinner, Collapsible, or Sheet proposals have shipped.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Maka inspected the releases, rebased the dependency patch, updated dependencies and generated artifacts, adapted existing test harnesses, ran verification, and drafted this PR. The commit carries `Generated-by: Maka`.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] chore(deps): upgrade Astryx to 0.6.6 [maka]

Posted by "Astro-Han (via GitHub) via commits" <co...@maka.apache.org>.
Astro-Han commented on PR #6012:
URL: https://github.com/apache/maka/pull/6012#issuecomment-6654024370

   Closing: `main` only takes fixes until `rust-preview` replaces it (#6366), and this upgrade is not a fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] chore(deps): upgrade Astryx to 0.6.6 [maka]

Posted by "Astro-Han (via GitHub) via commits" <co...@maka.apache.org>.
Astro-Han closed pull request #6012: chore(deps): upgrade Astryx to 0.6.6
URL: https://github.com/apache/maka/pull/6012


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org