[GitHub] spark pull request #16082: [SPARK-18652] Include the example data and third-...

[holdenk <gi...@git.apache.org>]

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16082#discussion_r90669850
  
    --- Diff: python/MANIFEST.in ---
    @@ -17,6 +17,8 @@
     global-exclude *.py[cod] __pycache__ .DS_Store
     recursive-include deps/jars *.jar
     graft deps/bin
    +graft deps/data
    --- End diff --
    
    Since we limit this to *.data and *.txt later would it make sense to restrict this here as well? That being said I can see an argument that we might have csv or tsv files in the future in which case we'd want to switch the include downstream to be * rather than just txt / data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org