You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2024/02/28 17:01:27 UTC
[PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
HappenLee opened a new pull request, #31563:
URL: https://github.com/apache/doris/pull/31563
## Proposed changes
Issue Number: close #31550
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1970247304
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1969460052
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1969531117
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 1a026c58c45eb2294abfdb511e76fc0ecc41533c with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 18.1 seconds inserted 10000000 Rows, about 552K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1969498065
<details>
<summary>TPC-H: <b>Total hot run time: 37557 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1a026c58c45eb2294abfdb511e76fc0ecc41533c, data reload: false
------ Round 1 ----------------------------------
q1 17743 4096 4014 4014
q2 2036 136 134 134
q3 10674 924 913 913
q4 4682 909 935 909
q5 7623 2868 2977 2868
q6 181 120 121 120
q7 1230 756 738 738
q8 9335 2001 2008 2001
q9 7158 6266 6289 6266
q10 8178 2488 2494 2488
q11 415 211 195 195
q12 794 310 312 310
q13 17955 3202 3202 3202
q14 283 249 249 249
q15 552 500 486 486
q16 465 397 422 397
q17 928 895 860 860
q18 6540 5915 5943 5915
q19 1551 1505 1508 1505
q20 548 273 274 273
q21 6758 3446 3569 3446
q22 809 287 268 268
Total cold run time: 106438 ms
Total hot run time: 37557 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4049 4046 4044 4044
q2 309 221 212 212
q3 2990 2949 2938 2938
q4 1890 1831 1841 1831
q5 5147 5138 5204 5138
q6 201 115 114 114
q7 2154 1709 1722 1709
q8 3118 3213 3211 3211
q9 8354 8352 8287 8287
q10 6086 3719 3672 3672
q11 507 417 425 417
q12 683 561 525 525
q13 8135 3293 3302 3293
q14 305 276 278 276
q15 537 499 491 491
q16 559 491 477 477
q17 1704 1691 1676 1676
q18 8781 7619 7386 7386
q19 2869 1642 1644 1642
q20 2080 1897 1892 1892
q21 4765 4631 4617 4617
q22 509 455 436 436
Total cold run time: 65732 ms
Total hot run time: 54284 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1969515868
<details>
<summary>TPC-DS: <b>Total hot run time: 169202 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1a026c58c45eb2294abfdb511e76fc0ecc41533c, data reload: false
query1 934 345 339 339
query2 6539 1732 1711 1711
query3 6710 208 204 204
query4 23269 20551 20481 20481
query5 4278 361 353 353
query6 254 169 169 169
query7 4609 290 286 286
query8 252 190 193 190
query9 8385 2265 2255 2255
query10 414 223 210 210
query11 14708 14165 14268 14165
query12 133 80 81 80
query13 1641 433 409 409
query14 8532 6533 6315 6315
query15 207 173 181 173
query16 7369 259 259 259
query17 1459 528 494 494
query18 1922 270 264 264
query19 183 146 146 146
query20 86 85 80 80
query21 206 122 114 114
query22 4814 4660 4648 4648
query23 30640 29826 29967 29826
query24 10928 3066 3151 3066
query25 625 356 356 356
query26 1687 160 173 160
query27 3040 302 308 302
query28 7031 1842 1844 1842
query29 1111 555 569 555
query30 286 134 140 134
query31 856 673 694 673
query32 100 57 58 57
query33 720 226 214 214
query34 1073 472 479 472
query35 814 724 753 724
query36 913 883 868 868
query37 128 62 63 62
query38 3054 3017 2986 2986
query39 1317 1255 1250 1250
query40 277 101 102 101
query41 37 38 35 35
query42 104 96 95 95
query43 443 425 413 413
query44 1077 692 696 692
query45 186 183 172 172
query46 1040 798 808 798
query47 1546 1457 1452 1452
query48 413 344 344 344
query49 1202 293 293 293
query50 770 366 361 361
query51 4368 4305 4260 4260
query52 96 90 84 84
query53 331 262 264 262
query54 298 225 229 225
query55 78 82 83 82
query56 218 195 200 195
query57 984 898 875 875
query58 212 191 189 189
query59 2132 2029 2081 2029
query60 245 225 219 219
query61 93 87 85 85
query62 598 374 357 357
query63 279 249 249 249
query64 6522 3110 3175 3110
query65 3258 3225 3217 3217
query66 1397 319 321 319
query67 14347 14057 14253 14057
query68 3877 544 552 544
query69 497 364 377 364
query70 1260 1184 1170 1170
query71 326 243 267 243
query72 5998 2850 2684 2684
query73 711 309 313 309
query74 6320 6073 6039 6039
query75 3014 2420 2421 2420
query76 2376 1060 1155 1060
query77 332 240 230 230
query78 8993 8590 8477 8477
query79 1131 513 534 513
query80 1005 354 351 351
query81 470 197 196 196
query82 1020 84 84 84
query83 225 122 117 117
query84 224 81 73 73
query85 1326 362 348 348
query86 371 274 309 274
query87 3317 3136 3120 3120
query88 2670 2255 2239 2239
query89 395 355 306 306
query90 1887 168 161 161
query91 148 120 122 120
query92 53 50 46 46
query93 1094 517 496 496
query94 1267 172 178 172
query95 429 336 349 336
query96 573 262 264 262
query97 4231 4160 4145 4145
query98 212 202 193 193
query99 1040 648 683 648
Total cold run time: 260570 ms
Total hot run time: 169202 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1969525943
<details>
<summary>ClickBench: <b>Total hot run time: 31.83 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1a026c58c45eb2294abfdb511e76fc0ecc41533c, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.03 0.03
query3 0.24 0.06 0.06
query4 1.66 0.10 0.10
query5 0.53 0.52 0.51
query6 1.29 0.71 0.65
query7 0.02 0.01 0.01
query8 0.03 0.02 0.02
query9 0.57 0.50 0.54
query10 0.59 0.56 0.57
query11 0.13 0.10 0.09
query12 0.12 0.10 0.10
query13 0.63 0.62 0.61
query14 0.80 0.79 0.80
query15 0.85 0.82 0.83
query16 0.35 0.38 0.38
query17 1.00 0.96 0.99
query18 0.26 0.26 0.24
query19 1.81 1.72 1.72
query20 0.02 0.01 0.01
query21 15.41 0.62 0.64
query22 3.85 3.74 2.11
query23 17.45 1.06 1.04
query24 2.12 0.78 0.19
query25 0.28 0.06 0.04
query26 0.18 0.13 0.15
query27 0.04 0.03 0.03
query28 12.13 0.83 0.83
query29 12.50 3.25 3.35
query30 0.58 0.52 0.52
query31 2.79 0.36 0.35
query32 3.37 0.49 0.48
query33 3.18 3.17 3.27
query34 15.36 4.78 4.79
query35 4.78 4.79 4.79
query36 1.13 1.07 1.07
query37 0.06 0.04 0.04
query38 0.04 0.03 0.02
query39 0.02 0.02 0.02
query40 0.16 0.12 0.14
query41 0.08 0.02 0.01
query42 0.02 0.01 0.02
query43 0.03 0.02 0.02
Total cold run time: 106.57 s
Total hot run time: 31.83 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1969440427
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1969495834
TeamCity be ut coverage result:
Function Coverage: 35.69% (8549/23952)
Line Coverage: 27.48% (69377/252435)
Region Coverage: 26.64% (35982/135059)
Branch Coverage: 23.45% (18389/78422)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1a026c58c45eb2294abfdb511e76fc0ecc41533c_1a026c58c45eb2294abfdb511e76fc0ecc41533c/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1969440567
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31563:
URL: https://github.com/apache/doris/pull/31563#issuecomment-1970247331
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](Func) Fix negative number in bitmap return error result [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31563:
URL: https://github.com/apache/doris/pull/31563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org