You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dblotsky <gi...@git.apache.org> on 2016/04/12 05:07:26 UTC
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/575
CB-10996 Updating docs index page to match new content.
@riknoll @nikhilkh @rakatyal @devgeeks please take a look when you have a moment.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs CB-10996
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #575
----
commit b2d80cae2803c68cdbab4e991b64ff8d4dd05c1f
Author: Dmitry Blotsky <dm...@gmail.com>
Date: 2016-04-12T02:37:05Z
CB-10996 Updating docs index page to match new content.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by devgeeks <gi...@git.apache.org>.
Github user devgeeks commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-208684628
Looks nice
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/575#discussion_r60801641
--- Diff: www/docs/en/dev/guide/support/index.md ---
@@ -19,6 +19,7 @@ license: >
title: Corodva support by platform
toc_title: Platform support
+description: Compatibility table for all major features.
--- End diff --
Plugins and features
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/575#discussion_r60801496
--- Diff: www/docs/en/dev/guide/hybrid/webviews/index.md ---
@@ -19,6 +19,7 @@ license: >
title: Embedding WebViews
toc_title: Embed Cordova in native apps
+description: Implement the Cordova WebView in your native project.
--- End diff --
Include the cordova Webview?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-212685445
@riknoll please give this another look. It's now using the changes from [CB-11126][1].
[1]: https://issues.apache.org/jira/browse/CB-11126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-213585837
LGTM! Just a few nitpicks on the descriptions themselves. Code looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-209013648
@dblotsky why change the headers from what's in the TOC? It might be a little weird to have two links on the page with different text going to the same place. Same with "Writing Apps/Plugins" vs. "Create Apps/Plugins". Also, why are some of the headings in the TOC here and others not? The platform guides need entries in my opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/575#discussion_r60801563
--- Diff: www/docs/en/dev/guide/appdev/whitelist/index.md ---
@@ -19,6 +19,7 @@ license: >
title: Whitelist Guide
toc_title: Whitelisting
+description: Grant an application access to external resources.
--- End diff --
Securely grant an application... Just trying to emphasize that this is a security feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/575#issuecomment-208684175
Screenshot:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org