You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by James Carman <ja...@carmanconsulting.com> on 2006/04/21 14:52:16 UTC
RE: Contributing Code
Be careful when putting code from an outside source into the ASF code base.
You might want to check with the incubator folks (I cc'ed them on this
message) about this. I would think that any code that is "donated" would
need to have the appropriate accompanying forms filled out, even if it is
just donated to an existing project.
-----Original Message-----
From: C. Grobmeier [mailto:grobmeier@possessed.de]
Sent: Friday, April 21, 2006 8:16 AM
To: Jakarta Commons Developers List
Subject: Re: Contributing Code
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
> I am interested in contributing code to commons. I wrote a
> ModifiableZip class, that basically implements all the methods on
> ZipFile, but provides new methods for adding, removing and modifying
> entries in an existing zip file.
> The basics work, but it is still a bit rough around the edges. I need
> to do a bit more work on
> 1) Getting the proper apis
> 2) Changing package names + general refactoring
> 3) Making sure there is less duplication between what I have and
> what is implemented in compress (there are common elements in
> org.apache.commons.compress.ZipOutputStream that I feel we could share)
> 4) Filling in some of the smaller bits like file attributes, etc.
> 5) There are some other known bugs
>
> I thought it made sense to contribute this now, and apply patches, since
> I figured this could be useful to the VFS folks, and thought it might be
> able to go into Compress, in which case being able to get feedback and
> requirements from the communities earlier (rather than later) will be
> useful.
>
this is great. I am doing work on compress at the moment, if you like i
send you the current code via email (i am not a comitter too). I will
check out your code and will try to put it into my current
implementation. It would be great if we could do this stuff together.
> The zip file is
> http://sandbox.sourcelabs.com/willpugh/myzip_contribution.zip
>
> I'm not an Apache committer. Should this be going through the incubator
> first?
IMHO not- it's just a enhancement to a allready incubatet codebase.
But i am not an expert on this stuff, so somebody please correct me if i
am writing bullshit.
Cheers,
Chris.
> Thanks,
> --Will
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
- --
Christian Grobmeier
Possessed Management
Hurlacher Str. 5 - 86853 Langerringen - Germany
E-Mail: grobmeier@possessed.de
Mobil: +(49)(0)175 57 66830
Fax: +(49) (0)8232 959119
Web: http://www.possessed.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFESMznkv8rKBUE/T4RAtmsAJ4kmHTv/9CjPT9/TtN9RwPHEmjSwwCeKxkE
heEsaUZ6fSqVTr5su6yUsDk=
=JBUM
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: Contributing Code
Posted by "C. Grobmeier" <gr...@possessed.de>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Thanks for the info. I will keep this in mind.
I have to fill out these forms too, so i will comment what has been
written be will too seperate the code again, if necessary.
Chris
James Carman wrote:
> Be careful when putting code from an outside source into the ASF code base.
> You might want to check with the incubator folks (I cc'ed them on this
> message) about this. I would think that any code that is "donated" would
> need to have the appropriate accompanying forms filled out, even if it is
> just donated to an existing project.
>
> -----Original Message-----
> From: C. Grobmeier [mailto:grobmeier@possessed.de]
> Sent: Friday, April 21, 2006 8:16 AM
> To: Jakarta Commons Developers List
> Subject: Re: Contributing Code
>
> Hi,
>
>>> I am interested in contributing code to commons. I wrote a
>>> ModifiableZip class, that basically implements all the methods on
>>> ZipFile, but provides new methods for adding, removing and modifying
>>> entries in an existing zip file.
>>> The basics work, but it is still a bit rough around the edges. I need
>>> to do a bit more work on
>>> 1) Getting the proper apis
>>> 2) Changing package names + general refactoring
>>> 3) Making sure there is less duplication between what I have and
>>> what is implemented in compress (there are common elements in
>>> org.apache.commons.compress.ZipOutputStream that I feel we could share)
>>> 4) Filling in some of the smaller bits like file attributes, etc.
>>> 5) There are some other known bugs
>>>
>>> I thought it made sense to contribute this now, and apply patches, since
>>> I figured this could be useful to the VFS folks, and thought it might be
>>> able to go into Compress, in which case being able to get feedback and
>>> requirements from the communities earlier (rather than later) will be
>>> useful.
>>>
>
> this is great. I am doing work on compress at the moment, if you like i
> send you the current code via email (i am not a comitter too). I will
> check out your code and will try to put it into my current
> implementation. It would be great if we could do this stuff together.
>
>>> The zip file is
>>> http://sandbox.sourcelabs.com/willpugh/myzip_contribution.zip
>>>
>>> I'm not an Apache committer. Should this be going through the incubator
>>> first?
>
> IMHO not- it's just a enhancement to a allready incubatet codebase.
> But i am not an expert on this stuff, so somebody please correct me if i
> am writing bullshit.
>
> Cheers,
> Chris.
>
>>> Thanks,
>>> --Will
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>>
>
>
> --
> Christian Grobmeier
> Possessed Management
> Hurlacher Str. 5 - 86853 Langerringen - Germany
> E-Mail: grobmeier@possessed.de
> Mobil: +(49)(0)175 57 66830
> Fax: +(49) (0)8232 959119
> Web: http://www.possessed.de
- ---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
- ---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
- --
Christian Grobmeier
Possessed Management
Hurlacher Str. 5 - 86853 Langerringen - Germany
E-Mail: grobmeier@possessed.de
Mobil: +(49)(0)175 57 66830
Fax: +(49) (0)8232 959119
Web: http://www.possessed.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFESNnckv8rKBUE/T4RAoZ+AJ9ONTgI8qBcwreyCOh+cgpCTRrExACfZ5eS
eCsp0IbqfT+G5zhwOyMfN0o=
=6FdO
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: Contributing Code
Posted by "C. Grobmeier" <gr...@possessed.de>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
will pugh wrote:
> I thought it made sense to go into compress, but I think that depends on
> how close compress is to releasing. As I mentioned before, this code
> has a number of things to finish before it's ready for primetime. I
> would estimate that I could get this ready in about a month. If this is
> too risky for compress, I would offer that we could start a new branch
> for the next version.
The compress code needs a lot of time before it's beeing released imho.
There are severeal things to do with tar, the interface must be extended
and so on. It's the right time to drop a new zip implementation in, if
this implementation fits all needs.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFETLzIkv8rKBUE/T4RAlpmAKCPGxchPNpcKKC2Zp8DCRMQMCz6AQCgkGh4
3eKUJ1j1OSTpKDbassa1muo=
=8ig4
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: Contributing Code
Posted by will pugh <wi...@sourcelabs.com>.
I think the appropriate processes for getting contributed code are the
ones outlined:
http://incubator.apache.org/ip-clearance/index.html
Using some of the forms linked to from:
http://www.apache.org/licenses/#grants
This process is predicated on there being a community for the code to go
to. For the ip-clearance section, I need to get a member to manage the
contribution. I thought this contribution made sense to go into
commons. Do folks agree?
If so, I'll be more than happy to go through the ip-clearance process,
but I need a member to volunteer for managing the donation, and a place
for it to go.
I thought it made sense to go into compress, but I think that depends on
how close compress is to releasing. As I mentioned before, this code
has a number of things to finish before it's ready for primetime. I
would estimate that I could get this ready in about a month. If this is
too risky for compress, I would offer that we could start a new branch
for the next version.
Does this make sense?
--Will
James Carman wrote:
>Be careful when putting code from an outside source into the ASF code base.
>You might want to check with the incubator folks (I cc'ed them on this
>message) about this. I would think that any code that is "donated" would
>need to have the appropriate accompanying forms filled out, even if it is
>just donated to an existing project.
>
>-----Original Message-----
>From: C. Grobmeier [mailto:grobmeier@possessed.de]
>Sent: Friday, April 21, 2006 8:16 AM
>To: Jakarta Commons Developers List
>Subject: Re: Contributing Code
>
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>Hi,
>
>
>
>>I am interested in contributing code to commons. I wrote a
>>ModifiableZip class, that basically implements all the methods on
>>ZipFile, but provides new methods for adding, removing and modifying
>>entries in an existing zip file.
>>The basics work, but it is still a bit rough around the edges. I need
>>to do a bit more work on
>> 1) Getting the proper apis
>> 2) Changing package names + general refactoring
>> 3) Making sure there is less duplication between what I have and
>>what is implemented in compress (there are common elements in
>>org.apache.commons.compress.ZipOutputStream that I feel we could share)
>> 4) Filling in some of the smaller bits like file attributes, etc.
>> 5) There are some other known bugs
>>
>>I thought it made sense to contribute this now, and apply patches, since
>>I figured this could be useful to the VFS folks, and thought it might be
>>able to go into Compress, in which case being able to get feedback and
>>requirements from the communities earlier (rather than later) will be
>>useful.
>>
>>
>>
>
>this is great. I am doing work on compress at the moment, if you like i
>send you the current code via email (i am not a comitter too). I will
>check out your code and will try to put it into my current
>implementation. It would be great if we could do this stuff together.
>
>
>
>>The zip file is
>>http://sandbox.sourcelabs.com/willpugh/myzip_contribution.zip
>>
>>I'm not an Apache committer. Should this be going through the incubator
>>first?
>>
>>
>
>IMHO not- it's just a enhancement to a allready incubatet codebase.
>But i am not an expert on this stuff, so somebody please correct me if i
>am writing bullshit.
>
>Cheers,
>Chris.
>
>
>
>> Thanks,
>> --Will
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>>
>
>
>- --
>Christian Grobmeier
>Possessed Management
>Hurlacher Str. 5 - 86853 Langerringen - Germany
>E-Mail: grobmeier@possessed.de
>Mobil: +(49)(0)175 57 66830
>Fax: +(49) (0)8232 959119
>Web: http://www.possessed.de
>-----BEGIN PGP SIGNATURE-----
>Version: GnuPG v1.4.2.1 (MingW32)
>Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
>iD8DBQFESMznkv8rKBUE/T4RAtmsAJ4kmHTv/9CjPT9/TtN9RwPHEmjSwwCeKxkE
>heEsaUZ6fSqVTr5su6yUsDk=
>=JBUM
>-----END PGP SIGNATURE-----
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org