You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/08 17:48:44 UTC

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5605: GEODE-8584: Message transmission fails with IllegalStateException in socket i/o code

dschneider-pivotal commented on a change in pull request #5605:
URL: https://github.com/apache/geode/pull/5605#discussion_r501899913



##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##########
@@ -52,6 +53,11 @@
 public class NioSslEngine implements NioFilter {
   private static final Logger logger = LogService.getLogger();
 
+  // this variable requires the MakeImmutable annotation but the buffer is empty and
+  // not really modifiable
+  @MakeImmutable
+  private static final ByteBuffer EMPTY_BUFFER = ByteBuffer.allocate(0);

Review comment:
       did you consider adding ".asReadOnlyBuffer()" so that this would be immutable?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org