You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2025/03/24 15:38:21 UTC
[I] Remove non-standard IconButton in favor of Ant Design 5 standard Card component [superset]
geido opened a new issue, #32823:
URL: https://github.com/apache/superset/issues/32823
Please refer to SIP-139 https://github.com/apache/superset/issues/29268.
The `src/components/IconButton` component should be removed and a standard `Card` component from Ant Design version 5 should be used instead.
The component is currently on used in the Database modal.
The codebase is moving to Ant Design 5. Similar work has been completed [here](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed).
When upgrading the component to Ant Design 5, please ensure to include:
- Do not use unnecessary custom styles. We want to go as vanilla Ant Design as possible.
- Proper RTL test coverage.
- A Storybook file.
- Include all relevant component options in the Storybook.
When opening a PR:
- Name your PR refactor({Component}): Refactor IconButton to use Ant Design 5 Card
- Add screenshots of BEFORE/AFTER in your PR.
- Make sure you or a committer has labeled your PR with [frontend:refactor:antd5](https://github.com/apache/superset/pulls?q=is%3Apr+label%3Afrontend%3Arefactor%3Aantd5+is%3Aclosed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Remove non-standard IconButton in favor of Ant Design 5 standard Card component [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #32823:
URL: https://github.com/apache/superset/issues/32823#issuecomment-2758479999
Hello @Sameerali0 are you still working on this issue? It seems that @fardin-developer has proposed a solution. Let us know if you also have a working solution. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Remove non-standard IconButton in favor of Ant Design 5 standard Card component [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #32823:
URL: https://github.com/apache/superset/issues/32823#issuecomment-2748564225
---
### 🎉 **Preset Bounty Available: $150 USD** 🎉
To claim this bounty, please carefully follow the steps below.
---
#### 📋 **Steps to Participate**
1. **Review Guidelines:**
Read through the [Preset Bounty Program Contribution Guide](https://preset.notion.site/preset-bounty-program-apache-superset) for complete details on bounty requirements.
2. **Show Your Interest:**
Complete the [Preset Bounty Program Survey](https://docs.google.com/forms/d/e/1FAIpQLSeDsR1iWvPxFydUIXs2agsUg3kMDaAooeD4P9P1L5sI0Yu5QQ/viewform?usp=sharing) and comment this issue to express your interest.
3. **Join the Slack Channel:**
After completing the survey, you’ll receive an invitation to the dedicated [Apache Superset Slack](https://join.slack.com/t/apache-superset/shared_invite/zt-2be0drwz8-bxPfkdz28ozzk1Iox29ufg) channel.
4. **Get Assigned:**
To officially start, ensure a **Bounty Program Manager** has assigned you to this issue.
5. **Submit Your Solution:**
When ready, submit your solution with the `Fixes #{issue_number}` notation in your Pull Request description.
6. **Claim Your Bounty:**
Sign up at [GitPay.me](https://gitpay.me/) and submit your solution via: [https://gitpay.me/#/task/1085](https://gitpay.me/#/task/1085)
---
#### 💡 **Additional Notes**
- Only developers assigned by a **Bounty Program Manager** should start working on this issue to win the bounty.
- Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.
Good luck, and happy coding! 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Remove non-standard IconButton in favor of Ant Design 5 standard Card component [superset]
Posted by "abhishek818 (via GitHub)" <gi...@apache.org>.
abhishek818 commented on issue #32823:
URL: https://github.com/apache/superset/issues/32823#issuecomment-2748570216
@geido can i take this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Remove non-standard IconButton in favor of Ant Design 5 standard Card component [superset]
Posted by "syedbarimanjan (via GitHub)" <gi...@apache.org>.
syedbarimanjan commented on issue #32823:
URL: https://github.com/apache/superset/issues/32823#issuecomment-2749740470
@geido I would like to work on this, sent you my implementation in slack dm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Remove non-standard IconButton in favor of Ant Design 5 standard Card component [superset]
Posted by "Sameerali0 (via GitHub)" <gi...@apache.org>.
Sameerali0 commented on issue #32823:
URL: https://github.com/apache/superset/issues/32823#issuecomment-2754913205
@geido I would like to start my journey with superset with this issue(I sent you my implementation plan in slack dm). Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Remove non-standard IconButton in favor of Ant Design 5 standard Card component [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido closed issue #32823: Remove non-standard IconButton in favor of Ant Design 5 standard Card component
URL: https://github.com/apache/superset/issues/32823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org