You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/15 07:56:49 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1786: support building external code into the OS, similar to how "external" apps work
xiaoxiang781216 commented on a change in pull request #1786:
URL: https://github.com/apache/incubator-nuttx/pull/1786#discussion_r488461305
##########
File path: tools/Directories.mk
##########
@@ -70,8 +70,13 @@ else
CLEANDIRS += $(APPDIR)
endif
-KERNDEPDIRS += sched drivers boards $(ARCH_SRC)
+KERNDEPDIRS += sched drivers boards $(ARCH_SRC)
Review comment:
Should we revert the change?
##########
File path: tools/Makefile.unix
##########
@@ -455,28 +462,28 @@ pass2dep: context tools/mkdeps$(HOSTEXEEXT) tools/cnvwindeps$(HOSTEXEEXT)
# file in the NuttX tools GIT repository for additional information.
config: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf Kconfig
oldconfig: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --oldconfig Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf --oldconfig Kconfig
olddefconfig: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf --olddefconfig Kconfig
Review comment:
Can we apply PR https://github.com/apache/incubator-nuttx/pull/1785 to APPSDIR and EXTERNALDIR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org