[GitHub] [spark] c21 commented on a change in pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

[GitBox <gi...@apache.org>]

c21 commented on a change in pull request #32242:
URL: https://github.com/apache/spark/pull/32242#discussion_r616404526



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala
##########
@@ -214,9 +214,9 @@ case class Grouping(child: Expression) extends Expression with Unevaluable
     Examples:
       > SELECT name, _FUNC_(), sum(age), avg(height) FROM VALUES (2, 'Alice', 165), (5, 'Bob', 180) people(age, name, height) GROUP BY cube(name, height);
         Alice	0	2	165.0
+        Bob	0	5	180.0

Review comment:
       This change is needed as hash aggregation output order is changed, and it causes `ExpressionInfoSuite.check outputs of expression examples` test failure in https://github.com/c21/spark/runs/2386397792?check_suite_focus=true .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org