You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by huor <gi...@git.apache.org> on 2016/05/04 10:12:36 UTC
[GitHub] incubator-hawq pull request: HAWQ-716. Support code coverage build...
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/636
HAWQ-716. Support code coverage build and report in hawq Makefile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq huor_codecoverage
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/636.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #636
----
commit 200ca3eaf0099c2082ac5e8e8789502e5f297427
Author: Ruilong Huo <rh...@pivotal.io>
Date: 2016-05-04T08:11:38Z
HAWQ-716. Support code coverage build and report in hawq Makefile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-716. Support code coverage build...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/636#discussion_r62446449
--- Diff: src/bin/gpfdist/Makefile ---
@@ -22,7 +22,8 @@ include $(top_builddir)/src/Makefile.global
LIBS := -levent -lyaml -lz -lbz2 -lssl -lcrypto
ifeq ($(BUILD_TYPE), gcov)
-LIBS := -lgcov $(LIBS)
+LIBS := -lgcov $(LIBS)
--- End diff --
The indent of LIBS is correct since it is consistent with CFLAGS in next line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-716. Support code coverage build...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/636#issuecomment-217767172
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-716. Support code coverage build...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the pull request:
https://github.com/apache/incubator-hawq/pull/636#issuecomment-216817192
1) You might want to avoid using the absolute path of lcov, etc. (users could install them anywhere).
2) Does the code check whether lcov packages have been installed at the configure stage?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-716. Support code coverage build...
Posted by huor <gi...@git.apache.org>.
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-716. Support code coverage build...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/636#discussion_r62446101
--- Diff: src/bin/gpfdist/Makefile ---
@@ -22,7 +22,8 @@ include $(top_builddir)/src/Makefile.global
LIBS := -levent -lyaml -lz -lbz2 -lssl -lcrypto
ifeq ($(BUILD_TYPE), gcov)
-LIBS := -lgcov $(LIBS)
+LIBS := -lgcov $(LIBS)
--- End diff --
indent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-716. Support code coverage build...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/636#issuecomment-217060325
@paul-guo-, please find my comments below:
1. it now uses lcov, gcov, genhtml directory instead of using the absolute path, assuming they are system search path
2. lcov, gcov, genhtml are checked in configure already
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-716. Support code coverage build...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the pull request:
https://github.com/apache/incubator-hawq/pull/636#issuecomment-217080556
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---