You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2014/11/09 04:58:11 UTC
Review Request 27784: Hosts bulk options: remove state filter on
start/stop all components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27784/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-8234
https://issues.apache.org/jira/browse/AMBARI-8234
Repository: ambari
Description
-------
Issue: Host list -> selected hosts -> start all components is refusing to work - says nothing to do.
*Reason*: start all components will filter all host components with 'desired state=INSTALLED' which should be "actual state=INSTALLED", so sometimes the filtered host components are empty, but in fact there are components need to start.
*Solution*: take out this HostRoles/state filtering and issue Start on all the host components for the selected hosts regardless of the actual state.
The server should just ignore Start command on host components whose actual state is STARTED.
Diffs
-----
ambari-web/app/controllers/main/host.js 80cf3e3
Diff: https://reviews.apache.org/r/27784/diff/
Testing
-------
Tested. Unit tests passed.
Thanks,
Xi Wang
Re: Review Request 27784: Hosts bulk options: remove state filter on
start/stop all components
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27784/#review60514
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Nov. 9, 2014, 3:58 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27784/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2014, 3:58 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-8234
> https://issues.apache.org/jira/browse/AMBARI-8234
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Issue: Host list -> selected hosts -> start all components is refusing to work - says nothing to do.
>
> *Reason*: start all components will filter all host components with 'desired state=INSTALLED' which should be "actual state=INSTALLED", so sometimes the filtered host components are empty, but in fact there are components need to start.
>
> *Solution*: take out this HostRoles/state filtering and issue Start on all the host components for the selected hosts regardless of the actual state.
> The server should just ignore Start command on host components whose actual state is STARTED.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js 80cf3e3
>
> Diff: https://reviews.apache.org/r/27784/diff/
>
>
> Testing
> -------
>
> Tested. Unit tests passed.
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 27784: Hosts bulk options: remove state filter on
start/stop all components
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27784/#review60513
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Nov. 9, 2014, 3:58 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27784/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2014, 3:58 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-8234
> https://issues.apache.org/jira/browse/AMBARI-8234
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Issue: Host list -> selected hosts -> start all components is refusing to work - says nothing to do.
>
> *Reason*: start all components will filter all host components with 'desired state=INSTALLED' which should be "actual state=INSTALLED", so sometimes the filtered host components are empty, but in fact there are components need to start.
>
> *Solution*: take out this HostRoles/state filtering and issue Start on all the host components for the selected hosts regardless of the actual state.
> The server should just ignore Start command on host components whose actual state is STARTED.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js 80cf3e3
>
> Diff: https://reviews.apache.org/r/27784/diff/
>
>
> Testing
> -------
>
> Tested. Unit tests passed.
>
>
> Thanks,
>
> Xi Wang
>
>