[jira] Commented: (DERBY-4686) SQLBinary.writeBlob is inefficient, reading one byte at a time from the source BLOB

["Kristian Waagan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877438#action_12877438 ] 

Kristian Waagan commented on DERBY-4686:
----------------------------------------

Thanks for the patch, Yun :)

The patch looks good. I think we can improve it by verifying that we actually transfer len bytes, and to avoid infinite loop in the case where there are fewer than len bytes in the stream.
We can probably reuse error msg SQLState.SET_STREAM_INEXACT_LENGTH_DATA (see ReaderToUTF8Stream.checkSufficientData).


Regards,

> SQLBinary.writeBlob is inefficient, reading one byte at a time from the source BLOB
> -----------------------------------------------------------------------------------
>
>                 Key: DERBY-4686
>                 URL: https://issues.apache.org/jira/browse/DERBY-4686
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions: 10.7.0.0
>            Reporter: Kristian Waagan
>            Assignee: Yun Lee
>         Attachments: DERBY-4686.diff
>
>
> SQLBinary.writeBlob is inefficient, since it is only reading one byte at the time from the source BLOB.
> It would be better if a transfer buffer was used to facilitate the write.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.