You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Jean-Louis Boudart <je...@gmail.com> on 2014/01/12 18:14:38 UTC
Ivy Code formatting
Hi there,
While fixing a bug i noticed that ivy source code was not fully formatted.
Eclipse formatter is not exported as a plain file but present through
eclipse project preferences in .settings folder [1].
Considering .settings folder is already commited i suggest to activate
"Saved actions" to apply on each save :
- code formatting
- organize import
I also suggest to apply formatting on whole project (could be done in a few
clicks with cleanup feature in eclipse).
Are you in favor of those code modifications ?
We could take the opportunity to cut this before 2.4.0 release.
PS: This could aslo applied on others subprojects (ant for example)
[1]
https://svn.apache.org/repos/asf/ant/ivy/core/trunk/.settings/org.eclipse.jdt.core.prefs
--
Jean Louis Boudart
Independent consultant
Apache EasyAnt commiter http://ant.apache.org/easyant/
Re: Ivy Code formatting
Posted by Nicolas Lalevée <ni...@hibnet.org>.
Le 12 janv. 2014 à 21:43, Jan Matèrne (jhm) <ap...@materne.de> a écrit :
> Maybe we could store the configuration files in the repo.
> E.g. Apache Camel does that in a way for multiple IDEs:
> https://github.com/apache/camel/tree/master/buildingtools
> https://github.com/apache/camel/tree/master/etc
We do store it in svn. That is what Jean-Louis is actually suggesting: changing the configuration for everybody since it's shared via svn. It is just spread in each project rather than centralized in an "etc" folder.
About the proposal, I am not a fan of "Saved actions" (probably because I will have to change a little bit my habits, lazy that I am !). But I don't care that much, I still can adapt myself. So +1 for the change.
Nicolas
>
> Jan
>
>> -----Ursprüngliche Nachricht-----
>> Von: Charles Duffy [mailto:charles@dyfis.net]
>> Gesendet: Sonntag, 12. Januar 2014 19:11
>> An: Ant Developers List
>> Betreff: Re: Ivy Code formatting
>>
>> +1
>>
>>
>> On Sun, Jan 12, 2014 at 11:14 AM, Jean-Louis Boudart <
>> jeanlouis.boudart@gmail.com> wrote:
>>
>>> Hi there,
>>>
>>> While fixing a bug i noticed that ivy source code was not fully
>> formatted.
>>> Eclipse formatter is not exported as a plain file but present through
>>> eclipse project preferences in .settings folder [1].
>>>
>>> Considering .settings folder is already commited i suggest to
>> activate
>>> "Saved actions" to apply on each save :
>>>
>>> - code formatting
>>> - organize import
>>>
>>>
>>> I also suggest to apply formatting on whole project (could be done in
>>> a few clicks with cleanup feature in eclipse).
>>>
>>> Are you in favor of those code modifications ?
>>>
>>> We could take the opportunity to cut this before 2.4.0 release.
>>>
>>> PS: This could aslo applied on others subprojects (ant for example)
>>>
>>> [1]
>>>
>>>
>> https://svn.apache.org/repos/asf/ant/ivy/core/trunk/.settings/org.ecli
>>> pse.jdt.core.prefs
>>>
>>> --
>>> Jean Louis Boudart
>>> Independent consultant
>>> Apache EasyAnt commiter http://ant.apache.org/easyant/
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: Ivy Code formatting
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
Maybe we could store the configuration files in the repo.
E.g. Apache Camel does that in a way for multiple IDEs:
https://github.com/apache/camel/tree/master/buildingtools
https://github.com/apache/camel/tree/master/etc
Jan
> -----Ursprüngliche Nachricht-----
> Von: Charles Duffy [mailto:charles@dyfis.net]
> Gesendet: Sonntag, 12. Januar 2014 19:11
> An: Ant Developers List
> Betreff: Re: Ivy Code formatting
>
> +1
>
>
> On Sun, Jan 12, 2014 at 11:14 AM, Jean-Louis Boudart <
> jeanlouis.boudart@gmail.com> wrote:
>
> > Hi there,
> >
> > While fixing a bug i noticed that ivy source code was not fully
> formatted.
> > Eclipse formatter is not exported as a plain file but present through
> > eclipse project preferences in .settings folder [1].
> >
> > Considering .settings folder is already commited i suggest to
> activate
> > "Saved actions" to apply on each save :
> >
> > - code formatting
> > - organize import
> >
> >
> > I also suggest to apply formatting on whole project (could be done in
> > a few clicks with cleanup feature in eclipse).
> >
> > Are you in favor of those code modifications ?
> >
> > We could take the opportunity to cut this before 2.4.0 release.
> >
> > PS: This could aslo applied on others subprojects (ant for example)
> >
> > [1]
> >
> >
> https://svn.apache.org/repos/asf/ant/ivy/core/trunk/.settings/org.ecli
> > pse.jdt.core.prefs
> >
> > --
> > Jean Louis Boudart
> > Independent consultant
> > Apache EasyAnt commiter http://ant.apache.org/easyant/
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Ivy Code formatting
Posted by Charles Duffy <ch...@dyfis.net>.
+1
On Sun, Jan 12, 2014 at 11:14 AM, Jean-Louis Boudart <
jeanlouis.boudart@gmail.com> wrote:
> Hi there,
>
> While fixing a bug i noticed that ivy source code was not fully formatted.
> Eclipse formatter is not exported as a plain file but present through
> eclipse project preferences in .settings folder [1].
>
> Considering .settings folder is already commited i suggest to activate
> "Saved actions" to apply on each save :
>
> - code formatting
> - organize import
>
>
> I also suggest to apply formatting on whole project (could be done in a few
> clicks with cleanup feature in eclipse).
>
> Are you in favor of those code modifications ?
>
> We could take the opportunity to cut this before 2.4.0 release.
>
> PS: This could aslo applied on others subprojects (ant for example)
>
> [1]
>
> https://svn.apache.org/repos/asf/ant/ivy/core/trunk/.settings/org.eclipse.jdt.core.prefs
>
> --
> Jean Louis Boudart
> Independent consultant
> Apache EasyAnt commiter http://ant.apache.org/easyant/
>
Re: Ivy Code formatting
Posted by Jean-Louis Boudart <je...@gmail.com>.
Done on trunk :)
2014/1/13 Charles Duffy <ch...@dyfis.net>
> Oops!
>
> My apologies for having forgotten this was pending when cutting the -rc1
> branch. Happy to update the branch after this change is in, before tagging
> and building something to formally propose for voting.
>
>
> On Sun, Jan 12, 2014 at 11:14 AM, Jean-Louis Boudart <
> jeanlouis.boudart@gmail.com> wrote:
>
> > Hi there,
> >
> > While fixing a bug i noticed that ivy source code was not fully
> formatted.
> > Eclipse formatter is not exported as a plain file but present through
> > eclipse project preferences in .settings folder [1].
> >
> > Considering .settings folder is already commited i suggest to activate
> > "Saved actions" to apply on each save :
> >
> > - code formatting
> > - organize import
> >
> >
> > I also suggest to apply formatting on whole project (could be done in a
> few
> > clicks with cleanup feature in eclipse).
> >
> > Are you in favor of those code modifications ?
> >
> > We could take the opportunity to cut this before 2.4.0 release.
> >
> > PS: This could aslo applied on others subprojects (ant for example)
> >
> > [1]
> >
> >
> https://svn.apache.org/repos/asf/ant/ivy/core/trunk/.settings/org.eclipse.jdt.core.prefs
> >
> > --
> > Jean Louis Boudart
> > Independent consultant
> > Apache EasyAnt commiter http://ant.apache.org/easyant/
> >
>
--
Jean Louis Boudart
Independent consultant
Apache EasyAnt commiter http://ant.apache.org/easyant/
Re: Ivy Code formatting
Posted by Charles Duffy <ch...@dyfis.net>.
Oops!
My apologies for having forgotten this was pending when cutting the -rc1
branch. Happy to update the branch after this change is in, before tagging
and building something to formally propose for voting.
On Sun, Jan 12, 2014 at 11:14 AM, Jean-Louis Boudart <
jeanlouis.boudart@gmail.com> wrote:
> Hi there,
>
> While fixing a bug i noticed that ivy source code was not fully formatted.
> Eclipse formatter is not exported as a plain file but present through
> eclipse project preferences in .settings folder [1].
>
> Considering .settings folder is already commited i suggest to activate
> "Saved actions" to apply on each save :
>
> - code formatting
> - organize import
>
>
> I also suggest to apply formatting on whole project (could be done in a few
> clicks with cleanup feature in eclipse).
>
> Are you in favor of those code modifications ?
>
> We could take the opportunity to cut this before 2.4.0 release.
>
> PS: This could aslo applied on others subprojects (ant for example)
>
> [1]
>
> https://svn.apache.org/repos/asf/ant/ivy/core/trunk/.settings/org.eclipse.jdt.core.prefs
>
> --
> Jean Louis Boudart
> Independent consultant
> Apache EasyAnt commiter http://ant.apache.org/easyant/
>