You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by "Knut Urdalen (JIRA)" <ji...@apache.org> on 2009/04/29 00:19:30 UTC

[jira] Created: (LOG4PHP-32) Refactor from using define to class contants

Refactor from using define to class contants
--------------------------------------------

                 Key: LOG4PHP-32
                 URL: https://issues.apache.org/jira/browse/LOG4PHP-32
             Project: Log4php
          Issue Type: Improvement
          Components: Code
            Reporter: Knut Urdalen
            Priority: Minor
             Fix For: 2.0


There is many places in the code where we can use class constants instead of define()'s. This will both improve readability and usage in my eyes in addition to a tiny speed improvement since defines are evaluated at runtime, while class constants are evaluated at compile time.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (LOG4PHP-32) Refactor from using define to class contants

Posted by "Christian Grobmeier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LOG4PHP-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Grobmeier resolved LOG4PHP-32.
----------------------------------------

    Resolution: Fixed

All constants are now defined at class level, not at a global level.
unit test run fine :-)

> Refactor from using define to class contants
> --------------------------------------------
>
>                 Key: LOG4PHP-32
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-32
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>            Reporter: Knut Urdalen
>            Priority: Minor
>             Fix For: 2.0
>
>
> There is many places in the code where we can use class constants instead of define()'s. This will both improve readability and usage in my eyes in addition to a tiny speed improvement since defines are evaluated at runtime, while class constants are evaluated at compile time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.