[jira] [Commented] (NIFI-4169) PutWebSocket processor with blank WebSocket session id attribute cannot transfer to failure queue

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162694#comment-16162694 ] 

ASF GitHub Bot commented on NIFI-4169:
--------------------------------------

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/2105
  
    This PR is now ready to get reviewed.
    
    A flow template is available here for testing both NiFi as a WebSocket client and server.
    https://gist.github.com/ijokarumawak/f36668b193bc413da3e0d968bb6b47c1
    
    This PR is based on the contribution from Y Wikander. 
    
    - Added "Fork Failed Broadcast Sessions" property to specify whether
      failed FlowFiles should be forked and transferred individually so that
      user can construct a error handling flow using each session id.
    - Added "Enable Detailed Failure Relationships" property to separate
      failure routes into more detailed ones, such as 'no connected sessions'
      or 'communication failure'
    - Added "websocket.broadcast.succeeded" and "websocket.broadcast.failed"
      attributes to outgoing FlowFiles when a message is broadcast.


> PutWebSocket processor with blank WebSocket session id attribute cannot transfer to failure queue
> -------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4169
>                 URL: https://issues.apache.org/jira/browse/NIFI-4169
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.3.0
>            Reporter: Y Wikander
>              Labels: patch
>         Attachments: 0001-websocket-when-sendMessage-fails-under-blank-session.patch, 0002-websocket-PutWebSocket-enhance-broadcast-support.patch
>
>
> If a PutWebSocket processor is setup with a blank WebSocket session id attribute (see NIFI-3318; Send message from PutWebSocket to all connected clients) and it is not connected to a websocket server it will log the failure and mark the flowfile with Success (rather than Failure) -- and the data is effectively lost.
> If there are multiple connected clients, and some succeed and others fail, routing Failure back into the PutWebSocket could result in duplicate data to some clients.
> Other NiFi processors seem to err on the side of "at least once".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)