You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Stefan Guggisberg (JIRA)" <ji...@apache.org> on 2010/06/09 11:14:26 UTC

[jira] Created: (JCR-2650) don't silently merge session-local transient changes with external changes before save().

don't silently merge session-local transient changes with external changes before save().
-----------------------------------------------------------------------------------------

                 Key: JCR-2650
                 URL: https://issues.apache.org/jira/browse/JCR-2650
             Project: Jackrabbit Content Repository
          Issue Type: Improvement
          Components: jackrabbit-core
            Reporter: Stefan Guggisberg


currently, external changes (i.e. changes committed by other sessions) are silently merged with transient changes. this might potentially cause concurrency issues/inconsistent transient state (see e.g. JCR-2632).

it would probably be better to isolate transient changes from external changes until they're saved (true copy-on-write). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2650) don't silently merge session-local transient changes with external changes before save().

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Guggisberg updated JCR-2650:
-----------------------------------

    Attachment: JCR-2650.patch

proposed patch

> don't silently merge session-local transient changes with external changes before save().
> -----------------------------------------------------------------------------------------
>
>                 Key: JCR-2650
>                 URL: https://issues.apache.org/jira/browse/JCR-2650
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Stefan Guggisberg
>         Attachments: JCR-2650.patch
>
>
> currently, external changes (i.e. changes committed by other sessions) are silently merged with transient changes. this might potentially cause concurrency issues/inconsistent transient state (see e.g. JCR-2632).
> it would probably be better to isolate transient changes from external changes until they're saved (true copy-on-write). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2650) don't silently merge session-local transient changes with external changes before save().

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Guggisberg updated JCR-2650:
-----------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

applied patch in trunk (svn r966697)

> don't silently merge session-local transient changes with external changes before save().
> -----------------------------------------------------------------------------------------
>
>                 Key: JCR-2650
>                 URL: https://issues.apache.org/jira/browse/JCR-2650
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Stefan Guggisberg
>             Fix For: 2.2.0
>
>         Attachments: JCR-2650 (cleaned).patch, JCR-2650.patch
>
>
> currently, external changes (i.e. changes committed by other sessions) are silently merged with transient changes. this might potentially cause concurrency issues/inconsistent transient state (see e.g. JCR-2632).
> it would probably be better to isolate transient changes from external changes until they're saved (true copy-on-write). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2650) don't silently merge session-local transient changes with external changes before save().

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Guggisberg updated JCR-2650:
-----------------------------------

           Status: Patch Available  (was: Open)
    Fix Version/s: 2.2.0

attached patch with proposed changes.

> don't silently merge session-local transient changes with external changes before save().
> -----------------------------------------------------------------------------------------
>
>                 Key: JCR-2650
>                 URL: https://issues.apache.org/jira/browse/JCR-2650
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Stefan Guggisberg
>             Fix For: 2.2.0
>
>         Attachments: JCR-2650.patch
>
>
> currently, external changes (i.e. changes committed by other sessions) are silently merged with transient changes. this might potentially cause concurrency issues/inconsistent transient state (see e.g. JCR-2632).
> it would probably be better to isolate transient changes from external changes until they're saved (true copy-on-write). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2650) don't silently merge session-local transient changes with external changes before save().

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Guggisberg updated JCR-2650:
-----------------------------------

    Attachment: JCR-2650 (cleaned).patch

new patch (removed some unwanted changes to test cases)

> don't silently merge session-local transient changes with external changes before save().
> -----------------------------------------------------------------------------------------
>
>                 Key: JCR-2650
>                 URL: https://issues.apache.org/jira/browse/JCR-2650
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Stefan Guggisberg
>             Fix For: 2.2.0
>
>         Attachments: JCR-2650 (cleaned).patch, JCR-2650.patch
>
>
> currently, external changes (i.e. changes committed by other sessions) are silently merged with transient changes. this might potentially cause concurrency issues/inconsistent transient state (see e.g. JCR-2632).
> it would probably be better to isolate transient changes from external changes until they're saved (true copy-on-write). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.