You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mateen Mansoori <ma...@gmail.com> on 2021/10/07 05:07:01 UTC
Review Request 73634: RANGER-3463 : Use apt logger to log messages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/
-----------------------------------------------------------
Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-3463
https://issues.apache.org/jira/browse/RANGER-3463
Repository: ranger
Description
-------
Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 98, 104.
Diffs
-----
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 925d2c76f
Diff: https://reviews.apache.org/r/73634/diff/1/
Testing
-------
Tested on local VM.
Thanks,
Mateen Mansoori
Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages
Posted by Mateen Mansoori <ma...@gmail.com>.
> On Oct. 7, 2021, 7:07 a.m., Kishor Gollapalliwar wrote:
> > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/73634/diff/1/?file=2253715#file2253715line124>
> >
> > Please consider restricting scope of this variable by declaring it inside IF block.
Here 'jsonEncKeyByAlgo' variable is required in outer if block as we are using the same in that block.
- Mateen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223581
-----------------------------------------------------------
On Oct. 7, 2021, 7:30 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2021, 7:30 a.m.)
>
>
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 98, 104.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 925d2c76f
>
>
> Diff: https://reviews.apache.org/r/73634/diff/2/
>
>
> Testing
> -------
>
> Tested on local VM.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages
Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223581
-----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Lines 67 (patched)
<https://reviews.apache.org/r/73634/#comment312664>
Please consider restricting scope of this variable by declaring it inside IF block.
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Lines 89 (patched)
<https://reviews.apache.org/r/73634/#comment312665>
Please consider restricting scope of this variable by declaring it inside IF block.
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Lines 120 (patched)
<https://reviews.apache.org/r/73634/#comment312666>
Please consider restricting scope of this variable by declaring it inside IF block.
- Kishor Gollapalliwar
On Oct. 7, 2021, 5:07 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2021, 5:07 a.m.)
>
>
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 98, 104.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 925d2c76f
>
>
> Diff: https://reviews.apache.org/r/73634/diff/1/
>
>
> Testing
> -------
>
> Tested on local VM.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages
Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223580
-----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 35 (original), 35 (patched)
<https://reviews.apache.org/r/73634/#comment312661>
Please consider removing un-necessary spaces.
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 123 (original), 124 (patched)
<https://reviews.apache.org/r/73634/#comment312662>
Please consider removing un-necessary spaces.
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java
Line 137 (original), 137 (patched)
<https://reviews.apache.org/r/73634/#comment312663>
Please consider removing un-necessary spaces.
- Kishor Gollapalliwar
On Oct. 7, 2021, 5:07 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2021, 5:07 a.m.)
>
>
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 98, 104.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 925d2c76f
>
>
> Diff: https://reviews.apache.org/r/73634/diff/1/
>
>
> Testing
> -------
>
> Tested on local VM.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages
Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223583
-----------------------------------------------------------
Ship it!
Ship It!
- Kishor Gollapalliwar
On Oct. 7, 2021, 7:30 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2021, 7:30 a.m.)
>
>
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 98, 104.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 925d2c76f
>
>
> Diff: https://reviews.apache.org/r/73634/diff/2/
>
>
> Testing
> -------
>
> Tested on local VM.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/#review223586
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Shah
On Oct. 7, 2021, 7:30 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73634/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2021, 7:30 a.m.)
>
>
> Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3463
> https://issues.apache.org/jira/browse/RANGER-3463
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 98, 104.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 925d2c76f
>
>
> Diff: https://reviews.apache.org/r/73634/diff/2/
>
>
> Testing
> -------
>
> Tested on local VM.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages
Posted by Mateen Mansoori <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73634/
-----------------------------------------------------------
(Updated Oct. 7, 2021, 7:30 a.m.)
Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
Changes
-------
Handled review comments.
Bugs: RANGER-3463
https://issues.apache.org/jira/browse/RANGER-3463
Repository: ranger
Description
-------
Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, 98, 104.
Diffs (updated)
-----
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 925d2c76f
Diff: https://reviews.apache.org/r/73634/diff/2/
Changes: https://reviews.apache.org/r/73634/diff/1-2/
Testing
-------
Tested on local VM.
Thanks,
Mateen Mansoori