You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/08/26 17:12:01 UTC

[jira] [Work logged] (KNOX-1995) If a rule doesn't match, shouldn't ERROR and return null

     [ https://issues.apache.org/jira/browse/KNOX-1995?focusedWorklogId=301363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301363 ]

ASF GitHub Bot logged work on KNOX-1995:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Aug/19 17:11
            Start Date: 26/Aug/19 17:11
    Worklog Time Spent: 10m 
      Work Description: risdenk commented on pull request #135: KNOX-1995 - If a rule doesn't match, shouldn't ERROR and return null
URL: https://github.com/apache/knox/pull/135
 
 
   ## What changes were proposed in this pull request?
   
   If an explicit rule doesn't match, log at `DEBUG` and return the original input.
   
   ## How was this patch tested?
   
   * `mvn -T.5C clean verify -Ppackage,release -Dshellcheck`
   * Manual checking of YARNUIV2 that exposed this error in the log in the first place
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 301363)
    Remaining Estimate: 0h
            Time Spent: 10m

> If a rule doesn't match, shouldn't ERROR and return null
> --------------------------------------------------------
>
>                 Key: KNOX-1995
>                 URL: https://issues.apache.org/jira/browse/KNOX-1995
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>             Fix For: 1.4.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently when an explicit rule doesn't match, we are throwing an ERROR and returning null. This causes NPEs later in the flow and instead should match the behavior of a non explicit rule. If the rule doesn't match, log only at DEBUG and return the original input.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)