You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Steve Niemitz <st...@tellapart.com> on 2015/03/03 16:26:10 UTC
Re: Review Request 31423: Stop the announcer and status checkers
before starting to kill the runners
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31423/#review74958
-----------------------------------------------------------
Is there anything else here? Is this ready to be merged?
- Steve Niemitz
On Feb. 26, 2015, 3:20 p.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31423/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 3:20 p.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop the announcer and status checkers before starting to kill the runners.
>
> This allows the task to be removed from the ZK ensemble before it begins getting killed. The delay can be significant if the task takes some time to shutdown, and during the time it stops responding to requests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/aurora_executor.py 9c0282392dbb9cca308baf47adc1750c1f5cacc6
> src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
> src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
>
> Diff: https://reviews.apache.org/r/31423/diff/
>
>
> Testing
> -------
>
> We're now running this in our production environments. Watching ZK, I can confirm that the nodes are removed before process shutdown begins. Watching the executor log also confirms this.
>
> I couldn't observe any other side effects either.
>
>
> Thanks,
>
> Steve Niemitz
>
>
Re: Review Request 31423: Stop the announcer and status checkers
before starting to kill the runners
Posted by Brian Wickman <wi...@apache.org>.
> On March 3, 2015, 3:26 p.m., Steve Niemitz wrote:
> > Is there anything else here? Is this ready to be merged?
Yup, on it.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31423/#review74958
-----------------------------------------------------------
On Feb. 26, 2015, 3:20 p.m., Steve Niemitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31423/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 3:20 p.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Stop the announcer and status checkers before starting to kill the runners.
>
> This allows the task to be removed from the ZK ensemble before it begins getting killed. The delay can be significant if the task takes some time to shutdown, and during the time it stops responding to requests.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/aurora_executor.py 9c0282392dbb9cca308baf47adc1750c1f5cacc6
> src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
> src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
>
> Diff: https://reviews.apache.org/r/31423/diff/
>
>
> Testing
> -------
>
> We're now running this in our production environments. Watching ZK, I can confirm that the nodes are removed before process shutdown begins. Watching the executor log also confirms this.
>
> I couldn't observe any other side effects either.
>
>
> Thanks,
>
> Steve Niemitz
>
>