You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "cshuo (via GitHub)" <gi...@apache.org> on 2026/07/23 03:27:33 UTC
[PR] [hudi-client] Improve native log and CDC write handle test coverage [hudi]
cshuo opened a new pull request, #19353:
URL: https://github.com/apache/hudi/pull/19353
### Describe the issue this Pull Request addresses
Closes #19352.
The native log format and CDC write handles in `hudi-client-common` lacked direct test coverage. This left record routing, file rollover, CDC supplemental logging modes, merge ordering, statistics publication, and representative failure handling insufficiently protected.
This PR adds focused tests and raises every class in scope above the 70% line-coverage target.
| Class | Before | After |
| --- | ---: | ---: |
| `HoodieNativeLogFormatWriter` | 0.0% | 84.7% |
| `HoodieNativeLogAppendHandle` | 0.0% | 71.7% |
| `FileGroupReaderBasedNativeLogAppendHandle` | 0.0% | 88.7% |
| `HoodieNativeCDCLogger` | 0.0% | 91.4% |
| `HoodieNativeCDCFileWriter` | 0.0% | 98.2% |
| `HoodieAvroNativeCDCLogger` | 0.0% | 90.9% |
| `HoodieSortedMergeHandle` | 0.0% | 77.5% |
| `HoodieMergeHandleWithChangeLog` | 0.0% | 83.9% |
### Summary and Changelog
#### Commit 1: test(client): improve native log and CDC write coverage (`4956c8de4d3`)
- Add native log append-handle tests for data/delete routing, rollover, write-count accounting, configured record keys, ignored records, lifecycle behavior, and flush failures.
- Cover file-group-reader append behavior, instant and read-stat propagation, write-status annotation, and failure wrapping.
- Exercise Avro and generic native CDC loggers for all supplemental logging modes across insert, update, delete, pending-record, retraction, and close paths.
- Extend native CDC file-writer coverage for file rolling, version collision handling, creation callbacks, partitioned/non-partitioned statistics, and I/O failures.
- Cover sorted merge ordering and pending inserts, plus insert/update CDC emission and status publication for change-log merge handles.
### Impact
- **Functional impact**: None. This is a test-only change and does not modify production behavior.
- **Maintainability**: Protects native log and CDC write paths against regressions with focused behavioral assertions.
- **Extensibility**: Provides test fixtures for adding native log formats, CDC modes, and merge-handle behavior.
### Risk Level
Low. The change only adds and extends unit tests. The targeted suite, Checkstyle, and Apache RAT all pass.
### Documentation Update
None.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Enough context is provided in the sections above
- [x] Adequate tests were added if applicable
- [x] `mvn -pl hudi-client/hudi-client-common -am -DskipTests -DskipITs -DskipSparkTests -DskipScalaTests checkstyle:check`
- [x] Native log/CDC targeted suite: 28 tests, 0 failures, 0 errors, 0 skipped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5066006483
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
}, {
"hash" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4956c8de4d3cb1a8d0462ba25679a2e716a57a0f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642)
* 5d8636b49959771cdac9f1cd07150d17b6ecd70a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5054034648
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4956c8de4d3cb1a8d0462ba25679a2e716a57a0f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5054839365
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4956c8de4d3cb1a8d0462ba25679a2e716a57a0f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5101229430
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
}, {
"hash" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674",
"triggerID" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"triggerType" : "PUSH"
}, {
"hash" : "d4fca992673af96029093dcb20b3961ee600faa5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15759",
"triggerID" : "d4fca992673af96029093dcb20b3961ee600faa5",
"triggerType" : "PUSH"
}, {
"hash" : "34379f1fb93bfd0cfeaf84cb8561f22834e75e67",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34379f1fb93bfd0cfeaf84cb8561f22834e75e67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4fca992673af96029093dcb20b3961ee600faa5 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15759)
* 34379f1fb93bfd0cfeaf84cb8561f22834e75e67 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5066551261
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
}, {
"hash" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674",
"triggerID" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d8636b49959771cdac9f1cd07150d17b6ecd70a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #19353:
URL: https://github.com/apache/hudi/pull/19353#discussion_r3642687180
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/TestHoodieNativeLogAppendHandle.java:
##########
@@ -0,0 +1,286 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io;
+
+import org.apache.hudi.common.config.RecordMergeMode;
+import org.apache.hudi.common.engine.LocalTaskContextSupplier;
+import org.apache.hudi.common.engine.RecordContext;
+import org.apache.hudi.common.fs.FSUtils;
+import org.apache.hudi.common.model.HoodieDeltaWriteStat;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.table.HoodieTableConfig;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.HoodieTableVersion;
+import org.apache.hudi.common.table.log.AppendResult;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieAppendException;
+import org.apache.hudi.io.cdc.HoodieNativeLogFormatWriter;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.table.HoodieTable;
+
+import org.junit.jupiter.api.Test;
+import org.mockito.MockedConstruction;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.HashMap;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockConstruction;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class TestHoodieNativeLogAppendHandle {
+
+ private static final String SCHEMA = "{\"type\":\"record\",\"name\":\"trip\",\"fields\":["
+ + "{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"ts\",\"type\":\"long\"}]}";
+
+ @Test
+ public void testCreatesWriterAndRoutesDataAndDeleteRecords() throws Exception {
+ HoodieWriteConfig config = config();
+ HoodieTable table = table(config);
+ HoodieRecord inputRecord = mock(HoodieRecord.class);
+ HoodieRecord populatedRecord = mock(HoodieRecord.class);
+ when(inputRecord.prependMetaFields(any(HoodieSchema.class), any(HoodieSchema.class), any(), any()))
+ .thenReturn(populatedRecord);
+
+ try (MockedConstruction<HoodieNativeLogFormatWriter> writers = mockConstruction(
+ HoodieNativeLogFormatWriter.class, (writer, context) -> {
+ when(writer.canWriteDataFile()).thenReturn(true);
+ when(writer.canWriteDeleteFile()).thenReturn(true);
+ when(writer.hasPendingWrites()).thenReturn(true);
+ when(writer.getLastAppendResults()).thenReturn(Collections.emptyList());
+ when(writer.getLogFile()).thenReturn(new HoodieLogFile(new StoragePath("/tmp/native.log.parquet")));
+ })) {
+ TestableNativeLogAppendHandle handle = new TestableNativeLogAppendHandle(config, table);
+ handle.createWriter();
+ HoodieNativeLogFormatWriter writer = writers.constructed().get(0);
+
+ handle.writeData(inputRecord, true);
+ verify(writer).appendRecord(eq(populatedRecord), any(HoodieSchema.class),
+ eq(HoodieRecord.RECORD_KEY_METADATA_FIELD));
+ handle.writeDeleteRecord(inputRecord);
+ verify(inputRecord).clearNewLocation();
+ verify(writer).appendDeleteRecord(eq(inputRecord), any(HoodieSchema.class),
+ eq(HoodieRecord.RECORD_KEY_METADATA_FIELD));
+
+ handle.flushWriter();
+ verify(writer).flushAppend(any());
+ assertEquals("/tmp/native.log.parquet", handle.logFilePath().toString());
+ assertTrue(handle.canWrite(inputRecord));
+ handle.closeWriter();
+ verify(writer).close();
+ }
+ }
+
+ @Test
+ public void testFlushesBeforeWriterRolloverAndTracksPerFileCounts() throws Exception {
+ HoodieWriteConfig config = config();
+ HoodieTable table = table(config);
+ HoodieRecord inputRecord = mock(HoodieRecord.class);
+ HoodieRecord populatedRecord = mock(HoodieRecord.class);
+ when(inputRecord.prependMetaFields(any(HoodieSchema.class), any(HoodieSchema.class), any(), any()))
+ .thenReturn(populatedRecord);
+
+ try (MockedConstruction<HoodieNativeLogFormatWriter> writers = mockConstruction(
+ HoodieNativeLogFormatWriter.class, (writer, context) -> {
+ when(writer.canWriteDataFile()).thenReturn(false);
+ when(writer.hasPendingWrites()).thenReturn(false);
Review Comment:
`canWriteDataFile()` forces `writeInsertAndUpdate()` to call `flushAppend()`, but this stub makes `flushAppend()` return immediately; the assertion below even verifies that no physical flush occurred. As a result, this does not cover the “flush before rollover” behavior or the counter reset performed by `processAppendResults()`. Please return `true` here, provide `getLastAppendResults()`, and verify the flush happens before the next append (and that the next file starts with reset counts).
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/cdc/TestHoodieNativeCDCLoggers.java:
##########
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io.cdc;
+
+import org.apache.hudi.common.avro.AvroRecordContext;
+import org.apache.hudi.common.engine.TaskContextSupplier;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.schema.HoodieSchemaUtils;
+import org.apache.hudi.common.table.HoodieTableConfig;
+import org.apache.hudi.common.table.cdc.HoodieCDCOperation;
+import org.apache.hudi.common.table.cdc.HoodieCDCSupplementalLoggingMode;
+import org.apache.hudi.common.table.log.LogFileCreationCallback;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericData;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.IndexedRecord;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+import org.mockito.ArgumentCaptor;
+import org.mockito.MockedConstruction;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_AFTER_IMAGE;
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_BEFORE_IMAGE;
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_COMMIT_TIMESTAMP;
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_OPERATION_TYPE;
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_RECORD_KEY;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockConstruction;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class TestHoodieNativeCDCLoggers {
+
+ private static final String COMMIT_TIME = "100";
+ private static final HoodieSchema DATA_SCHEMA = HoodieSchema.fromAvroSchema(new Schema.Parser().parse(
+ "{\"type\":\"record\",\"name\":\"trip\",\"namespace\":\"org.apache.hudi\",\"fields\":["
+ + "{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"name\",\"type\":\"string\"}]}"));
+ private static final HoodieSchema SCHEMA_WITH_METADATA = HoodieSchemaUtils.addMetadataFields(DATA_SCHEMA);
+
+ @ParameterizedTest
+ @EnumSource(HoodieCDCSupplementalLoggingMode.class)
+ public void testAvroLoggerWritesAllOperationsAndSupportsRetraction(
+ HoodieCDCSupplementalLoggingMode mode) throws Exception {
+ try (MockedConstruction<HoodieNativeCDCFileWriter> mockedWriters = mockConstruction(HoodieNativeCDCFileWriter.class)) {
+ HoodieAvroNativeCDCLogger logger = new HoodieAvroNativeCDCLogger(
+ COMMIT_TIME, mock(HoodieWriteConfig.class), tableConfig(mode), "partition",
+ mock(HoodieStorage.class), SCHEMA_WITH_METADATA, new StoragePath("/tmp/partition"),
+ "file-1", "1-0-1", new LogFileCreationCallback() {
+ }, mock(TaskContextSupplier.class));
+ HoodieNativeCDCFileWriter<IndexedRecord> writer = mockedWriters.constructed().get(0);
+ Map<String, Long> expectedStats = Collections.singletonMap("partition/file.cdc.parquet", 10L);
+ when(writer.getCDCWriteStats()).thenReturn(expectedStats);
+
+ GenericRecord oldRecord = record("id-1", "old");
+ GenericRecord newRecord = record("id-1", "new");
+ logger.put("id-1", oldRecord, Option.of(newRecord));
+ verify(writer, never()).write(anyString(), any());
+ logger.put("id-2", null, Option.of(record("id-2", "insert")));
+ logger.put("id-3", oldRecord, Option.empty());
+ logger.put("id-4", null, Option.of(record("id-4", "retracted")));
+ logger.remove("different-key");
+ logger.remove("id-4");
+ logger.close();
+
+ assertSame(expectedStats, logger.getCDCWriteStats());
+ verify(writer, times(3)).write(anyString(), any());
+ verify(writer).close();
+
+ ArgumentCaptor<IndexedRecord> recordCaptor = ArgumentCaptor.forClass(IndexedRecord.class);
+ verify(writer, times(3)).write(anyString(), recordCaptor.capture());
+ List<IndexedRecord> cdcRecords = recordCaptor.getAllValues();
+ assertCDCRecord((GenericRecord) cdcRecords.get(0), mode, HoodieCDCOperation.UPDATE, "id-1");
Review Comment:
These assertions validate only the operation/key and removal of Hudi metadata fields. In `DATA_BEFORE` / `DATA_BEFORE_AFTER`, a transformer that swaps the old/new images, emits the wrong `name`, or leaves an image null can still pass. Since this test is the coverage for all supplemental logging modes, please assert the actual before/after image values (`old` and `new`) for update, plus the expected null/non-null images for insert/delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5101030989
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/19353?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.19%. Comparing base ([`d56e674`](https://app.codecov.io/gh/apache/hudi/commit/d56e6747f43c7388d0cdd6e27ef5afab82de360e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d4fca99`](https://app.codecov.io/gh/apache/hudi/commit/d4fca992673af96029093dcb20b3961ee600faa5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19353 +/- ##
=========================================
Coverage 72.19% 72.19%
Complexity 32595 32595
=========================================
Files 2561 2561
Lines 148328 148328
Branches 18654 18654
=========================================
Hits 107087 107087
Misses 32774 32774
Partials 8467 8467
```
| [Components](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hudi-common](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.41% <ø> (ø)` | |
| [hudi-client](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.56% <ø> (ø)` | |
| [hudi-flink](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.63% <ø> (ø)` | |
| [hudi-spark-datasource](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.66% <ø> (ø)` | |
| [hudi-utilities](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.42% <ø> (ø)` | |
| [hudi-cli](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.32% <ø> (ø)` | |
| [hudi-hadoop](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.49% <ø> (ø)` | |
| [hudi-sync](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.64% <ø> (ø)` | |
| [hudi-io](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.57% <ø> (ø)` | |
| [hudi-timeline-service](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.44% <ø> (ø)` | |
| [hudi-cloud](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.00% <ø> (ø)` | |
| [hudi-kafka-connect](https://app.codecov.io/gh/apache/hudi/pull/19353/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.20% <ø> (ø)` | |
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/19353/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/19353/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.25% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5101549941
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
}, {
"hash" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674",
"triggerID" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"triggerType" : "PUSH"
}, {
"hash" : "d4fca992673af96029093dcb20b3961ee600faa5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15759",
"triggerID" : "d4fca992673af96029093dcb20b3961ee600faa5",
"triggerType" : "PUSH"
}, {
"hash" : "34379f1fb93bfd0cfeaf84cb8561f22834e75e67",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15762",
"triggerID" : "34379f1fb93bfd0cfeaf84cb8561f22834e75e67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4fca992673af96029093dcb20b3961ee600faa5 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15759)
* 34379f1fb93bfd0cfeaf84cb8561f22834e75e67 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15762)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #19353:
URL: https://github.com/apache/hudi/pull/19353#discussion_r3642808189
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/cdc/TestHoodieNativeCDCLoggers.java:
##########
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io.cdc;
+
+import org.apache.hudi.common.avro.AvroRecordContext;
+import org.apache.hudi.common.engine.TaskContextSupplier;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.schema.HoodieSchemaUtils;
+import org.apache.hudi.common.table.HoodieTableConfig;
+import org.apache.hudi.common.table.cdc.HoodieCDCOperation;
+import org.apache.hudi.common.table.cdc.HoodieCDCSupplementalLoggingMode;
+import org.apache.hudi.common.table.log.LogFileCreationCallback;
+import org.apache.hudi.common.table.read.BufferedRecord;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.StoragePath;
+
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericData;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.generic.IndexedRecord;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+import org.mockito.ArgumentCaptor;
+import org.mockito.MockedConstruction;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_AFTER_IMAGE;
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_BEFORE_IMAGE;
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_COMMIT_TIMESTAMP;
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_OPERATION_TYPE;
+import static org.apache.hudi.common.table.cdc.HoodieCDCUtils.CDC_RECORD_KEY;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockConstruction;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class TestHoodieNativeCDCLoggers {
+
+ private static final String COMMIT_TIME = "100";
+ private static final HoodieSchema DATA_SCHEMA = HoodieSchema.fromAvroSchema(new Schema.Parser().parse(
+ "{\"type\":\"record\",\"name\":\"trip\",\"namespace\":\"org.apache.hudi\",\"fields\":["
+ + "{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"name\",\"type\":\"string\"}]}"));
+ private static final HoodieSchema SCHEMA_WITH_METADATA = HoodieSchemaUtils.addMetadataFields(DATA_SCHEMA);
+
+ @ParameterizedTest
+ @EnumSource(HoodieCDCSupplementalLoggingMode.class)
+ public void testAvroLoggerWritesAllOperationsAndSupportsRetraction(
+ HoodieCDCSupplementalLoggingMode mode) throws Exception {
+ try (MockedConstruction<HoodieNativeCDCFileWriter> mockedWriters = mockConstruction(HoodieNativeCDCFileWriter.class)) {
+ HoodieAvroNativeCDCLogger logger = new HoodieAvroNativeCDCLogger(
+ COMMIT_TIME, mock(HoodieWriteConfig.class), tableConfig(mode), "partition",
+ mock(HoodieStorage.class), SCHEMA_WITH_METADATA, new StoragePath("/tmp/partition"),
+ "file-1", "1-0-1", new LogFileCreationCallback() {
+ }, mock(TaskContextSupplier.class));
+ HoodieNativeCDCFileWriter<IndexedRecord> writer = mockedWriters.constructed().get(0);
+ Map<String, Long> expectedStats = Collections.singletonMap("partition/file.cdc.parquet", 10L);
+ when(writer.getCDCWriteStats()).thenReturn(expectedStats);
+
+ GenericRecord oldRecord = record("id-1", "old");
+ GenericRecord newRecord = record("id-1", "new");
+ logger.put("id-1", oldRecord, Option.of(newRecord));
+ verify(writer, never()).write(anyString(), any());
+ logger.put("id-2", null, Option.of(record("id-2", "insert")));
+ logger.put("id-3", oldRecord, Option.empty());
+ logger.put("id-4", null, Option.of(record("id-4", "retracted")));
+ logger.remove("different-key");
+ logger.remove("id-4");
+ logger.close();
+
+ assertSame(expectedStats, logger.getCDCWriteStats());
+ verify(writer, times(3)).write(anyString(), any());
+ verify(writer).close();
+
+ ArgumentCaptor<IndexedRecord> recordCaptor = ArgumentCaptor.forClass(IndexedRecord.class);
+ verify(writer, times(3)).write(anyString(), recordCaptor.capture());
+ List<IndexedRecord> cdcRecords = recordCaptor.getAllValues();
+ assertCDCRecord((GenericRecord) cdcRecords.get(0), mode, HoodieCDCOperation.UPDATE, "id-1");
Review Comment:
Fixed in 5d8636b4995. The tests now validate before/after image IDs, names, and nullability for update, insert, and delete across every supplemental logging mode while retaining metadata projection checks.
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/TestHoodieNativeLogAppendHandle.java:
##########
@@ -0,0 +1,286 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io;
+
+import org.apache.hudi.common.config.RecordMergeMode;
+import org.apache.hudi.common.engine.LocalTaskContextSupplier;
+import org.apache.hudi.common.engine.RecordContext;
+import org.apache.hudi.common.fs.FSUtils;
+import org.apache.hudi.common.model.HoodieDeltaWriteStat;
+import org.apache.hudi.common.model.HoodieFileFormat;
+import org.apache.hudi.common.model.HoodieLogFile;
+import org.apache.hudi.common.model.HoodieRecord;
+import org.apache.hudi.common.schema.HoodieSchema;
+import org.apache.hudi.common.table.HoodieTableConfig;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.HoodieTableVersion;
+import org.apache.hudi.common.table.log.AppendResult;
+import org.apache.hudi.common.util.Option;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieAppendException;
+import org.apache.hudi.io.cdc.HoodieNativeLogFormatWriter;
+import org.apache.hudi.storage.HoodieStorage;
+import org.apache.hudi.storage.StoragePath;
+import org.apache.hudi.table.HoodieTable;
+
+import org.junit.jupiter.api.Test;
+import org.mockito.MockedConstruction;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.HashMap;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockConstruction;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class TestHoodieNativeLogAppendHandle {
+
+ private static final String SCHEMA = "{\"type\":\"record\",\"name\":\"trip\",\"fields\":["
+ + "{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"ts\",\"type\":\"long\"}]}";
+
+ @Test
+ public void testCreatesWriterAndRoutesDataAndDeleteRecords() throws Exception {
+ HoodieWriteConfig config = config();
+ HoodieTable table = table(config);
+ HoodieRecord inputRecord = mock(HoodieRecord.class);
+ HoodieRecord populatedRecord = mock(HoodieRecord.class);
+ when(inputRecord.prependMetaFields(any(HoodieSchema.class), any(HoodieSchema.class), any(), any()))
+ .thenReturn(populatedRecord);
+
+ try (MockedConstruction<HoodieNativeLogFormatWriter> writers = mockConstruction(
+ HoodieNativeLogFormatWriter.class, (writer, context) -> {
+ when(writer.canWriteDataFile()).thenReturn(true);
+ when(writer.canWriteDeleteFile()).thenReturn(true);
+ when(writer.hasPendingWrites()).thenReturn(true);
+ when(writer.getLastAppendResults()).thenReturn(Collections.emptyList());
+ when(writer.getLogFile()).thenReturn(new HoodieLogFile(new StoragePath("/tmp/native.log.parquet")));
+ })) {
+ TestableNativeLogAppendHandle handle = new TestableNativeLogAppendHandle(config, table);
+ handle.createWriter();
+ HoodieNativeLogFormatWriter writer = writers.constructed().get(0);
+
+ handle.writeData(inputRecord, true);
+ verify(writer).appendRecord(eq(populatedRecord), any(HoodieSchema.class),
+ eq(HoodieRecord.RECORD_KEY_METADATA_FIELD));
+ handle.writeDeleteRecord(inputRecord);
+ verify(inputRecord).clearNewLocation();
+ verify(writer).appendDeleteRecord(eq(inputRecord), any(HoodieSchema.class),
+ eq(HoodieRecord.RECORD_KEY_METADATA_FIELD));
+
+ handle.flushWriter();
+ verify(writer).flushAppend(any());
+ assertEquals("/tmp/native.log.parquet", handle.logFilePath().toString());
+ assertTrue(handle.canWrite(inputRecord));
+ handle.closeWriter();
+ verify(writer).close();
+ }
+ }
+
+ @Test
+ public void testFlushesBeforeWriterRolloverAndTracksPerFileCounts() throws Exception {
+ HoodieWriteConfig config = config();
+ HoodieTable table = table(config);
+ HoodieRecord inputRecord = mock(HoodieRecord.class);
+ HoodieRecord populatedRecord = mock(HoodieRecord.class);
+ when(inputRecord.prependMetaFields(any(HoodieSchema.class), any(HoodieSchema.class), any(), any()))
+ .thenReturn(populatedRecord);
+
+ try (MockedConstruction<HoodieNativeLogFormatWriter> writers = mockConstruction(
+ HoodieNativeLogFormatWriter.class, (writer, context) -> {
+ when(writer.canWriteDataFile()).thenReturn(false);
+ when(writer.hasPendingWrites()).thenReturn(false);
Review Comment:
Fixed in 5d8636b4995. The test now supplies pending append results, verifies the flush occurs before the rollover append, and checks that the next data file starts with reset counts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5066031340
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
}, {
"hash" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674",
"triggerID" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4956c8de4d3cb1a8d0462ba25679a2e716a57a0f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642)
* 5d8636b49959771cdac9f1cd07150d17b6ecd70a Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #19353:
URL: https://github.com/apache/hudi/pull/19353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5100203930
@cshuo I think there are some failing CI tests, can you please help to fix them? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5054063862
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4956c8de4d3cb1a8d0462ba25679a2e716a57a0f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5102388026
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
}, {
"hash" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674",
"triggerID" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"triggerType" : "PUSH"
}, {
"hash" : "d4fca992673af96029093dcb20b3961ee600faa5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15759",
"triggerID" : "d4fca992673af96029093dcb20b3961ee600faa5",
"triggerType" : "PUSH"
}, {
"hash" : "34379f1fb93bfd0cfeaf84cb8561f22834e75e67",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15762",
"triggerID" : "34379f1fb93bfd0cfeaf84cb8561f22834e75e67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34379f1fb93bfd0cfeaf84cb8561f22834e75e67 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15762)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5101016210
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
}, {
"hash" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674",
"triggerID" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"triggerType" : "PUSH"
}, {
"hash" : "d4fca992673af96029093dcb20b3961ee600faa5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15759",
"triggerID" : "d4fca992673af96029093dcb20b3961ee600faa5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d8636b49959771cdac9f1cd07150d17b6ecd70a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674)
* d4fca992673af96029093dcb20b3961ee600faa5 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15759)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): improve native log and CDC write coverage [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19353:
URL: https://github.com/apache/hudi/pull/19353#issuecomment-5100976278
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15642",
"triggerID" : "4956c8de4d3cb1a8d0462ba25679a2e716a57a0f",
"triggerType" : "PUSH"
}, {
"hash" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674",
"triggerID" : "5d8636b49959771cdac9f1cd07150d17b6ecd70a",
"triggerType" : "PUSH"
}, {
"hash" : "d4fca992673af96029093dcb20b3961ee600faa5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4fca992673af96029093dcb20b3961ee600faa5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5d8636b49959771cdac9f1cd07150d17b6ecd70a Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=15674)
* d4fca992673af96029093dcb20b3961ee600faa5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org