Re: [PR] risc-v/k230: revise k230 hart operations and kernel linker script. [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #11691:
URL: https://github.com/apache/nuttx/pull/11691#discussion_r1491009437


##########
arch/risc-v/src/k230/k230_hart.c:
##########
@@ -70,12 +72,27 @@
 
 #define ASM               __asm__ __volatile__
 
+/* Hart reset control bits and delays */
+
+#define RESET_DONE_BIT     (1 << 12)
+#define RESET_RQST_BIT     (1 << 0)
+#define RESET_DONE_ENW     (1 << (12 + 16))
+#define RESET_RQST_ENW     (1 << (0 + 16))
+
+#define RESET_WAIT_USEC    100
+
 /****************************************************************************
- * Private Functions
+ * Private Variables
  ****************************************************************************/
 
 #if !defined(CONFIG_BUILD_KERNEL) || defined(CONFIG_NUTTSBI)
 
+static bool _big = false;     /* true if running on big core */

Review Comment:
   ```suggestion
   static bool g_big = false;     /* true if running on big core */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org