You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/21 13:47:01 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2014: Add the optional interrupt stack to the Xtensa architecture

masayuki2009 commented on a change in pull request #2014:
URL: https://github.com/apache/incubator-nuttx/pull/2014#discussion_r509298199



##########
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##########
@@ -68,6 +68,19 @@
 #include "chip_macros.h"
 #include "xtensa_timer.h"
 
+#if !defined(CONFIG_SMP) && CONFIG_ARCH_INTERRUPTSTACK > 15
+ .data
+ .align     16

Review comment:
       For Xtensa architecture, does .align 16 means 16-byte alignment?
   For ARM architecture, .align means 2^n but it confuses me. So I will refactor them.
   
   However, we can use .balign instead of .align.
   Please see the following URL.
   https://developer.arm.com/documentation/dui0742/c/migrating-arm-syntax-assembly-code-to-gnu-syntax/alignment
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org