You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by jg...@apache.org on 2019/05/20 14:56:21 UTC
[kafka] branch trunk updated: MINOR: Add log when the consumer does
not send an offset commit due to not being part of an active group (#6404)
This is an automated email from the ASF dual-hosted git repository.
jgus pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5a30a80 MINOR: Add log when the consumer does not send an offset commit due to not being part of an active group (#6404)
5a30a80 is described below
commit 5a30a806ec1502cab34555bfa4df4fc6ed7a7917
Author: Stanislav Kozlovski <fa...@windowslive.com>
AuthorDate: Mon May 20 15:56:07 2019 +0100
MINOR: Add log when the consumer does not send an offset commit due to not being part of an active group (#6404)
Reviewers: Jason Gustafson <ja...@confluent.io>
---
.../clients/consumer/internals/ConsumerCoordinator.java | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
index 260756b..3aef0c5 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
@@ -810,16 +810,17 @@ public final class ConsumerCoordinator extends AbstractCoordinator {
}
final Generation generation;
- if (subscriptions.partitionsAutoAssigned())
+ if (subscriptions.partitionsAutoAssigned()) {
generation = generation();
- else
+ // if the generation is null, we are not part of an active group (and we expect to be).
+ // the only thing we can do is fail the commit and let the user rejoin the group in poll()
+ if (generation == null) {
+ log.info("Failing OffsetCommit request since the consumer is not part of an active group");
+ return RequestFuture.failure(new CommitFailedException());
+ }
+ } else
generation = Generation.NO_GENERATION;
- // if the generation is null, we are not part of an active group (and we expect to be).
- // the only thing we can do is fail the commit and let the user rejoin the group in poll()
- if (generation == null)
- return RequestFuture.failure(new CommitFailedException());
-
OffsetCommitRequest.Builder builder = new OffsetCommitRequest.Builder(
new OffsetCommitRequestData()
.setGroupId(this.groupId)