You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Oliver Deakin (JIRA)" <ji...@apache.org> on 2008/09/10 12:30:46 UTC
[jira] Created: (HARMONY-5976) [classlib] Results of static
analysis
[classlib] Results of static analysis
-------------------------------------
Key: HARMONY-5976
URL: https://issues.apache.org/jira/browse/HARMONY-5976
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Oliver Deakin
Assignee: Oliver Deakin
I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630178#action_12630178 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Fixed failures in modules/luni/src/main/native/vmls/shared/vmls.c at r694234.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin updated HARMONY-5976:
-----------------------------------
Attachment: results.zip
Attaching zip of analysis results files
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629781#action_12629781 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Fixed failures in modules/print/src/main/native/print/windows/win_printer_factory.c at r693814.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629799#action_12629799 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Looks like the failure in modules\portlib\src\main\native\pool\shared\pool.c is a false positive, as there will never be 0 elements in the pool.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630156#action_12630156 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Fix failure in modules/awt/src/main/native/win32wrapper/windows/WinDataTransfer.cpp at r694211.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629778#action_12629778 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
I should have also mentioned - this was run against a Windows build, and as such only contains checks for shared or Windows specific source.
Fixed failures in modules/awt/src/main/native/gl/windows/GDIBlitter.cpp at r693809.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629767#action_12629767 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Fixed failures in modules\awt\src\main\native\fontlib\shared\Environment.cpp at r693790.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629773#action_12629773 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Thanks Mark!
Fixed failures in modules/awt/src/main/native/fontlib/shared/ParsingTables.cpp at r693806.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631431#action_12631431 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
I think so - apart from the failures in dblparse.c. IMHO without some serious effort investigating the algorithm implemented in the function in question and then some time spent understanding how the code relates to that algorithm, it will be hard to determine whether the errors in that file are valid. As we have seen no test failures in that code, I am happy to skip over those reported errors until we have better reason to invest the time in them (e.g. a failing app).
If noone objects, Ill mark this as resolved.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629788#action_12629788 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Fixed failures in modules/print/src/main/native/print/windows/print.cpp at r693826.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631426#action_12631426 ]
Mark Hindess commented on HARMONY-5976:
---------------------------------------
I fixed the file.c issue (slightly indirectly) with my commit at r578050.
Are all of these dealt with now?
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631695#action_12631695 ]
Tim Ellison commented on HARMONY-5976:
--------------------------------------
How about re-running the tool to see if we introduced any new problems ;-)
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630154#action_12630154 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Fixed failures in modules/awt/src/main/native/winfont/windows/winFont.cpp at r694210.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631711#action_12631711 ]
Oliver Deakin commented on HARMONY-5976:
----------------------------------------
Since there were no objections on the list, fixed failures in modules/awt/src/main/native/gl/windows/WinGraphicsEnvironment.cpp at r696220.
I have rerun the tool against the latest source and I see no new failures :)
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630135#action_12630135 ]
Tim Ellison commented on HARMONY-5976:
--------------------------------------
Fixed failures in modules\luni\src\main\native\luni\windows\OSNetworkSystemWin32.c at r694187.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5976) [classlib] Results of static analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin closed HARMONY-5976.
----------------------------------
I believe all the issues have been fixed and a rerun of the tool has shown we have not introduced any new failures. Closing...
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629769#action_12629769 ]
Mark Hindess commented on HARMONY-5976:
---------------------------------------
I'm looking at the file.c issues.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin resolved HARMONY-5976.
------------------------------------
Resolution: Fixed
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5976) [classlib] Results of static
analysis
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629786#action_12629786 ]
Tim Ellison commented on HARMONY-5976:
--------------------------------------
Fixed failure in modules\portlib\src\main\native\port\windows\hysock.c at r693823.
> [classlib] Results of static analysis
> -------------------------------------
>
> Key: HARMONY-5976
> URL: https://issues.apache.org/jira/browse/HARMONY-5976
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: Oliver Deakin
> Attachments: results.zip
>
>
> I ran an IBM static analysis tool over the classlib native code and have trimmed out the (what I believe are) false-positives. I will attach the report files for the failures I believe to be valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.