[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #3889: Allow configuring collection of statistics during TPC-H benchmarks

[GitBox <gi...@apache.org>]

Dandandan commented on code in PR #3889:
URL: https://github.com/apache/arrow-datafusion/pull/3889#discussion_r998887827


##########
benchmarks/src/bin/tpch.rs:
##########
@@ -98,6 +98,10 @@ struct DataFusionBenchmarkOpt {
     /// Path to output directory where JSON summary file should be written to
     #[structopt(parse(from_os_str), short = "o", long = "output")]
     output_path: Option<PathBuf>,
+
+    /// Whether to disable collection of statistics (and cost based optimizations) or not.
+    #[structopt(short = "S", long = "disable-statistics")]

Review Comment:
   It might be good to keep defaults the same as datafusion-cli (statistics disabled)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org