You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/11/16 19:11:21 UTC

[GitHub] [activemq-artemis] gtully commented on a change in pull request #3344: ARTEMIS-2990 - update wildcard address map on creation only, avoid du…

gtully commented on a change in pull request #3344:
URL: https://github.com/apache/activemq-artemis/pull/3344#discussion_r524509090



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -37,7 +36,7 @@
 
    private final boolean containsWildCard;
 
-   private List<Address> linkedAddresses = null;
+   private final List<Address> linkedAddresses = new ArrayList<>();

Review comment:
       there is an impact, it is reverted to lazy init via https://github.com/apache/activemq-artemis/pull/3343 where a set works better for deletions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org