You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/23 13:56:08 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #5356: server: detach data disks before destroying vms
weizhouapache opened a new pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356
### Description
This PR fixes #4902
The testing results with this change:
- When destroy VM without expunge and when no data disk is selected for deletion
destroy vm: VM is stopped, data disk is detached from vm (in Ready state)
recover vm: vm is ready only with root disk.
- When destroy VM without expunge and when one or more data disks are selected for deletion
destroy vm: VM is stopped, Data disks marked for deletion are detached and in Destroy state . the remaining disks are detached from VM
recover vm: vm is ready only with root disk.
recover data disk in Destroy: volume is ready, and not attached to vm.
- When destroy VM with expunge and when no data disk is selected for deletion
VM is destroyed and expunged completely.
data disks are detached from vm.
- When destroy VM with expunge and few data disks are selected for deletion
VM is destroyed and expunged completely.
Data disks marked for deletion are deleted. the remaining disks are detached from VM
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-904418234
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907115258
@weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch if it's a bug fix. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907207136
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907254690
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-904302274
@weizhouapache can you target this PR to the main branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-904383922
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-904945375
<b>Trillian test result (tid-1761)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33898 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5356-t1761-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907206770
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907255197
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907064675
clgtm, tests done. I've given the failed travis tests another spin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907225290
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907543992
<b>Trillian test result (tid-1814)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35434 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5356-t1814-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-907119819
> @weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch if it's a bug fix. Thanks.
@rhtyd @nvazquez changed base branch back to 4.15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-906457603
> Tested with multiple DataDisks, all 4 scenarios work as expected
great, thanks for testing @davidjumani
@rhtyd @PaulAngus @DaanHoogland @nvazquez
are the expected results correct to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-904383266
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-903800773
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-904516959
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-903799415
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-904516314
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5356: server: detach data disks before destroying vms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5356:
URL: https://github.com/apache/cloudstack/pull/5356#issuecomment-903825365
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org