[GitHub] flink pull request #4795: [FLINK-7793] [flip6] Defer slot release to Resourc...

[tillrohrmann <gi...@git.apache.org>]

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4795

    [FLINK-7793] [flip6] Defer slot release to ResourceManager

    ## What is the purpose of the change
    
    This commit changes the SlotManager behaviour such that upon a TaskManager timeout
    the ResourceManager is only notified about it without removing the slots. The
    ResourceManager can then decide whether it stops the TaskManager and removes the slots
    from the SlotManager or to keep the TaskManager still around.
    
    ## Brief change log
    
    - Rename `ResourceManagerActions` into `ResourceActions`
    - Remove automatic slot removal from `SlotManager` in case of `TaskManager` timeout
    - Add `ResourceManager#releaseResource` method which removes the slots depending on the `stopWorker` call
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - `SlotManagerTest#testTaskManagerTimeoutDoesNotRemoveSlots`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixTaskManagerRelease

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4795
    
----
commit 6b7aec2ce3799a35ed21bd04345abe0ab0b8298e
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-10-10T14:15:53Z

    [FLINK-7653] Properly implement Dispatcher#requestClusterOverview
    
    This commit implements the ClusterOverview generation on the Dispatcher. In
    order to do this, the Dispatcher requests the ResourceOverview from the
    ResourceManager and the job status from all JobMasters. After receiving all
    information, it is compiled into the ClusterOverview.
    
    Note: StatusOverview has been renamed to ClusterOverview

commit 62b7ffd1ca924320ddb5a32073358f5b3c53be74
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-10-10T16:39:40Z

    [FLINK-7793] [flip6] Defer slot release to ResourceManager
    
    This commit changes the SlotManager behaviour such that upon a TaskManager timeout
    the ResourceManager is only notified about it without removing the slots. The
    ResourceManager can then decide whether it stops the TaskManager and removes the slots
    from the SlotManager or to keep the TaskManager still around.
    
    Add test case

----


---

[GitHub] flink issue #4795: [FLINK-7793] [flip6] Defer slot release to ResourceManage...

[tillrohrmann <gi...@git.apache.org>]

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4795
  
    Rebased onto the latest master. Waiting for Travis to give green light before merging.


---

[GitHub] flink pull request #4795: [FLINK-7793] [flip6] Defer slot release to Resourc...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4795


---

[GitHub] flink issue #4795: [FLINK-7793] [flip6] Defer slot release to ResourceManage...

[tillrohrmann <gi...@git.apache.org>]

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4795
  
    Failing test cases are unrelated.


---