You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/21 13:38:29 UTC
[GitHub] [airflow] mjpieters commented on a change in pull request #7370: [AIRFLOW-6590] Use batch db operations in jobs
mjpieters commented on a change in pull request #7370:
URL: https://github.com/apache/airflow/pull/7370#discussion_r509290320
##########
File path: airflow/cli/commands/task_command.py
##########
@@ -169,8 +169,6 @@ def task_run(args, dag=None):
task = dag.get_task(task_id=args.task_id)
ti = TaskInstance(task, args.execution_date)
- ti.refresh_from_db()
Review comment:
This actually broke task logging for multiple tries, see 11717, because setting up logging _looks at the attributes of the TI_, via the `[logging].log_filename_template` setting.
##########
File path: airflow/cli/commands/task_command.py
##########
@@ -169,8 +169,6 @@ def task_run(args, dag=None):
task = dag.get_task(task_id=args.task_id)
ti = TaskInstance(task, args.execution_date)
- ti.refresh_from_db()
Review comment:
This actually broke task logging for multiple tries, see #11717, because setting up logging _looks at the attributes of the TI_, via the `[logging].log_filename_template` setting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org