[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #448: [YUNIKORN-1276] REST API for specific application

[GitBox <gi...@apache.org>]

wilfred-s commented on code in PR #448:
URL: https://github.com/apache/yunikorn-k8shim/pull/448#discussion_r949770099


##########
test/e2e/framework/helpers/yunikorn/rest_api_utils.go:
##########
@@ -128,19 +128,14 @@ func (c *RClient) GetApps(partition string, queueName string) ([]map[string]inte
 	return apps, err
 }
 
-func (c *RClient) GetAppInfo(partition string, queueName string, appID string) (map[string]interface{}, error) {
-	apps, err := c.GetApps(partition, queueName)
+func (c *RClient) GetAppInfo(partition string, queueName string, appID string) (*dao.ApplicationDAOInfo, error) {

Review Comment:
   This signature change should trigger updates in all callers. Looking at the code there are at least 7 callers of this function.
   We also need to become consistent in the way we call and process: either always return a `dao` type object for the thing we request or the generic `[]interface{}`.  I think `dao` is the only correct answer.
   We already use `dao` for queue and partition but not for application...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org