[GitHub] [commons-codec] kinow commented on a change in pull request #111: CODEC-285 JUnit v5 parallel assertions

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #111:
URL: https://github.com/apache/commons-codec/pull/111#discussion_r810546976



##########
File path: src/test/java/org/apache/commons/codec/net/URLCodecTest.java
##########
@@ -129,14 +130,19 @@ public void testEncodeDecodeNull() throws Exception {
 
 
     @Test
-    public void testDecodeInvalid() throws Exception {
+    public void testDecodeInvalid() {
         final URLCodec urlCodec = new URLCodec();
-        assertThrows(DecoderException.class, () -> urlCodec.decode("%"));
-        assertThrows(DecoderException.class, () -> urlCodec.decode("%A"));
-        // Bad 1st char after %
-        assertThrows(DecoderException.class, () -> urlCodec.decode("%A"));
-        // Bad 2nd char after %
-        assertThrows(DecoderException.class, () -> urlCodec.decode("%0W"));
+
+        assertAll(
+                () -> assertThrows(DecoderException.class, () -> urlCodec.decode("%")),
+
+                // Bad 1st char after %
+                () -> assertThrows(DecoderException.class, () -> urlCodec.decode("%A")),

Review comment:
       Hm, isn't it missing one call from the existing code above? Using `%A`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org