{ACS44] exception leading up to blokker issue

[Daan Hoogland <da...@gmail.com>]

In error reports coming from the citrix qa department I see
stacktraces that lead back to snippets like
        } catch (final Throwable e) {
            throw new CloudRuntimeException("Caught: " + pstmt, e);
        }

the caught exception is
Caused by: java.lang.NullPointerException
    at com.cloud.utils.db.GenericDaoBase.prepareAttribute(GenericDaoBase.java:1469)
    at com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:402)
    ... 46 more

close inspection shows that the generated sql code reads

SELECT service_offering_view.id, service_offering_view.uuid,
service_offering_view.name, service_offering_view.display_text,
service_offering_view.tags, service_offering_view.use_local_storage,
service_offering_view.system_use, service_offering_view.cpu,
service_offering_view.speed, service_offering_view.ram_size,
service_offering_view.nw_rate, service_offering_view.mc_rate,
service_offering_view.ha_enabled, service_offering_view.limit_cpu_use,
service_offering_view.is_volatile, service_offering_view.host_tag,
service_offering_view.default_use, service_offering_view.vm_type,
service_offering_view.customized_iops, service_offering_view.min_iops,
service_offering_view.max_iops, service_offering_view.hv_ss_reserve,
service_offering_view.sort_key, service_offering_view.bytes_read_rate,
service_offering_view.bytes_write_rate,
service_offering_view.iops_read_rate,
service_offering_view.iops_write_rate, service_offering_view.created,
service_offering_view.removed, service_offering_view.domain_id,
service_offering_view.domain_uuid, service_offering_view.domain_name,
service_offering_view.domain_path,
service_offering_view.deployment_planner FROM service_offering_view
WHERE service_offering_view.system_use = 1  AND  AND
service_offering_view.removed IS NULL  ORDER BY
service_offering_view.sort_key DESC  LIMIT 0, 500

note the double AND in the WHERE clause.

It may or may not be related to the issue this log was provided with
but it is very disconcerning. Is there a Dao guru with time to look at
this?

thanks
-- 
Daan