You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Remko Popma (JIRA)" <ji...@apache.org> on 2013/04/26 18:44:15 UTC

[jira] [Resolved] (LOG4J2-217) PluginManager does not close streams if exceptions occur during plugin init

     [ https://issues.apache.org/jira/browse/LOG4J2-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Remko Popma resolved LOG4J2-217.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0-beta6

Fixed in revision 1476286. 
                
> PluginManager does not close streams if exceptions occur during plugin init
> ---------------------------------------------------------------------------
>
>                 Key: LOG4J2-217
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-217
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0-beta4
>            Reporter: Remko Popma
>             Fix For: 2.0-beta6
>
>         Attachments: LOG4J2-217-close-finally.patch
>
>
> If an exception occurs during plugin initialization, 
> the currently open Log4j2Plugins.dat file is not closed, because
> the call to inputstream.close is not in a finally block.
> o.a.l.l.c.c.p.PluginManager#decode(ClassLoader) line 234
> This may cause the issue reported by Fabian in the log4j-user mailing list:
> From: Fabien Sanglard <fsanglard <at> timeplay.com>
> Subject: Issue with Tomcat auto-redeploy on Windows.
> Newsgroups: gmane.comp.jakarta.log4j.user
> Date: 2013-04-17 20:28:37 GMT (4 days, 13 hours and 8 minutes ago)
> It seems there is an issue with log4j 2 not closing the core JAR handle on Windows.
> It prevents Tomcat from auto redeploying an app.
> Upon updating an hypothetical DiscoveryService.war in the 'webapps' folder, the redeploy will fail:
> SEVERE: [C:\Program Files\apache-tomcat-7.0.39\webapps\DiscoveryService\WEB-INF\lib] could 
> not be completely deleted. The presence of the remaining files may cause problems
> Upon inspection it looks like:
> C:\Program Files\apache-tomcat-7.0.39\webapps\DiscoveryService\WEB-INF\lib\log4j-core-2.0-beta4.jar
> Cannot be deleted :/ ! Is there anything special to do so log4j 2 close the JAR handle ?
> Fab

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org