You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/18 16:34:55 UTC

[GitHub] [fineract] vorburger commented on issue #738: GSIM and GLIM with test cases (FINERACT-603)

vorburger commented on issue #738: GSIM and GLIM with test cases (FINERACT-603)
URL: https://github.com/apache/fineract/pull/738#issuecomment-615900020
 
 
   > I'll try to make time for a more details rewiew of this (big!) PR hopefully in the coming days.
   
   I glanced over this today, and have 1 major feedback re. the OpenJPA configuration changes proposed here (re. `EagerFetchMode` & `SubclassFetchMode`) - personally I would much prefer to see this brought up completely separately, and not "tucked away" hidden inside this PR....
   
   Other than that, this is a (big, thank you!) functional change which others than me would be better place to review; I've just replied on the "Re: Re-opening Pull Request and Writing Test Cases for https://github.com/apache/fineract/pull/527" thread on the dev list with a request for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services