You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2014/08/29 00:47:08 UTC
svn commit: r1621220 - in
/httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol:
RequestAuthenticationBase.java ResponseAuthCache.java
Author: sebb
Date: Thu Aug 28 22:47:08 2014
New Revision: 1621220
URL: http://svn.apache.org/r1621220
Log:
Document missing case labels
Modified:
httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/RequestAuthenticationBase.java
httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/ResponseAuthCache.java
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/RequestAuthenticationBase.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/RequestAuthenticationBase.java?rev=1621220&r1=1621219&r2=1621220&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/RequestAuthenticationBase.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/RequestAuthenticationBase.java Thu Aug 28 22:47:08 2014
@@ -58,7 +58,7 @@ abstract class RequestAuthenticationBase
final HttpContext context) {
AuthScheme authScheme = authState.getAuthScheme();
Credentials creds = authState.getCredentials();
- switch (authState.getState()) {
+ switch (authState.getState()) { // TODO add UNCHALLENGED and HANDSHAKE cases
case FAILURE:
return;
case SUCCESS:
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/ResponseAuthCache.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/ResponseAuthCache.java?rev=1621220&r1=1621219&r2=1621220&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/ResponseAuthCache.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java-deprecated/org/apache/http/client/protocol/ResponseAuthCache.java Thu Aug 28 22:47:08 2014
@@ -91,7 +91,7 @@ public class ResponseAuthCache implement
authCache = new BasicAuthCache();
context.setAttribute(ClientContext.AUTH_CACHE, authCache);
}
- switch (targetState.getState()) {
+ switch (targetState.getState()) { // TODO add SUCCESS, UNCHALLENGED and HANDSHAKE cases
case CHALLENGED:
cache(authCache, target, targetState.getAuthScheme());
break;
@@ -112,7 +112,7 @@ public class ResponseAuthCache implement
authCache = new BasicAuthCache();
context.setAttribute(ClientContext.AUTH_CACHE, authCache);
}
- switch (proxyState.getState()) {
+ switch (proxyState.getState()) { // TODO add SUCCESS, UNCHALLENGED and HANDSHAKE cases
case CHALLENGED:
cache(authCache, proxy, proxyState.getAuthScheme());
break;