You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Cédric Champeau <ce...@gmail.com> on 2015/07/13 09:42:40 UTC
[RESULT] [VOTE] Release Apache Groovy 2.4.4-incubating
Hi all!
Vote for the release of Apache Groovy 2.4.4-incubating has passed with 7 +1
votes (6 binding) and 1 (one) -1 binding vote. We will now ask the IPMC to
vote on the release.
+1 votes:
IPMC:
Emmanuel Lécharny
PPMC:
Cédric Champeau
Guillaume Laforge
Pascal Schumacher
Paul King
Jochen Theodorou
Non binding:
Steve Amerige
0 votes
(none)
-1 votes
Andrés Almiray
Vote thread:
http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201507.mbox/%3CCADQzvm%3DzDNCxpOua3LQ1ZNo62Aq40QZM7SJwgER5MfkArWrTeA%40mail.gmail.com%3E
Re: [RESULT] [VOTE] Release Apache Groovy 2.4.4-incubating
Posted by Jochen Theodorou <bl...@gmx.org>.
Am 13.07.2015 17:49, schrieb Emmanuel Lécharny:
[...]
>>> Do you have a special configuration in Git for end lines?
>
> No. If I have to take care of thet, then consider adding a warning in
> the Readme.
normally git converts line endings without any special configuration, as
long as they are source files. Of course if they have been converted
through th build, then having a ^M at the end, as it is required o s
files is not surprising. Another effect of the release system I assume
byeblackdrg
--
Jochen "blackdrag" Theodorou
blog: http://blackdragsview.blogspot.com/
Re: [RESULT] [VOTE] Release Apache Groovy 2.4.4-incubating
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 13/07/15 16:49, Cédric Champeau a écrit :
>>> It would also be cool to have it
>>>> for the various OS aorund there (Mac OSX, Linux and Windows).
>>>>
>>>>
>>> It's not different for Mac/Linux. But for windows, we might need an
>>> additional '.bat' to the instructions. I'm not sure.
>> Either you tell people they must build the packages under linux/mac, and
>> that's enough, or you tell people what's specific about windows. In any
>> case, I tested the build, and it fails if I don't remove the ^M at the
>> end of the batche files.
>>
>> Do you have a special configuration in Git for end lines?
No. If I have to take care of thet, then consider adding a warning in
the Readme.
Re: [RESULT] [VOTE] Release Apache Groovy 2.4.4-incubating
Posted by Cédric Champeau <ce...@gmail.com>.
2015-07-13 16:45 GMT+02:00 Emmanuel Lécharny <el...@gmail.com>:
> Le 13/07/15 16:07, Cédric Champeau a écrit :
> >> I suggest that the README should be completed with clear instruction
> for.
> >> those who don't have gradlew installed.
> >
> > There *is* such a section:
> >
> https://github.com/apache/incubator-groovy/#unpacking-the-src-distribution
>
> This is a section about unpacking, not about building the sources. If
> you read the '== Building from Source' section, it's all about gradlew.
>
> Just clarify it, it would be useful.
>
Right, because if you read it in order, you can't miss it: unzip, install
Gradle, execute "gradle", then everything else with "gradlew". It would be
*much* easier if the wrapper was whitelisted, but....
>
> >
> > It would also be cool to have it
> >> for the various OS aorund there (Mac OSX, Linux and Windows).
> >>
> >>
> > It's not different for Mac/Linux. But for windows, we might need an
> > additional '.bat' to the instructions. I'm not sure.
>
> Either you tell people they must build the packages under linux/mac, and
> that's enough, or you tell people what's specific about windows. In any
> case, I tested the build, and it fails if I don't remove the ^M at the
> end of the batche files.
>
> Do you have a special configuration in Git for end lines?
Re: [RESULT] [VOTE] Release Apache Groovy 2.4.4-incubating
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 13/07/15 16:07, Cédric Champeau a écrit :
>> I suggest that the README should be completed with clear instruction for.
>> those who don't have gradlew installed.
>
> There *is* such a section:
> https://github.com/apache/incubator-groovy/#unpacking-the-src-distribution
This is a section about unpacking, not about building the sources. If
you read the '== Building from Source' section, it's all about gradlew.
Just clarify it, it would be useful.
>
> It would also be cool to have it
>> for the various OS aorund there (Mac OSX, Linux and Windows).
>>
>>
> It's not different for Mac/Linux. But for windows, we might need an
> additional '.bat' to the instructions. I'm not sure.
Either you tell people they must build the packages under linux/mac, and
that's enough, or you tell people what's specific about windows. In any
case, I tested the build, and it fails if I don't remove the ^M at the
end of the batche files.
Re: [RESULT] [VOTE] Release Apache Groovy 2.4.4-incubating
Posted by Cédric Champeau <ce...@gmail.com>.
> I suggest that the README should be completed with clear instruction for.
> those who don't have gradlew installed.
There *is* such a section:
https://github.com/apache/incubator-groovy/#unpacking-the-src-distribution
It would also be cool to have it
> for the various OS aorund there (Mac OSX, Linux and Windows).
>
>
It's not different for Mac/Linux. But for windows, we might need an
additional '.bat' to the instructions. I'm not sure.
> Same thing for Rat : having some text explaining how to run it would help.
>
>
>
Re: [RESULT] [VOTE] Release Apache Groovy 2.4.4-incubating
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 13/07/15 10:01, Andres Almiray a écrit :
> I think my vote (-1) is non binding ;-)
>
> And again, the only reason I voted as such is because I couldn't get a
> clean binary distribution from the source package by following the
> instructions to the letter. RAT complained about a missing header on a
> build related file. I know is silly but it needs fixing. Other than that
> the binaries look good to me!
I suggest that the README should be completed with clear instruction for
those who don't have gradlew installed. It would also be cool to have it
for the various OS aorund there (Mac OSX, Linux and Windows).
Same thing for Rat : having some text explaining how to run it would help.
Re: [RESULT] [VOTE] Release Apache Groovy 2.4.4-incubating
Posted by Andres Almiray <aa...@gmail.com>.
I think my vote (-1) is non binding ;-)
And again, the only reason I voted as such is because I couldn't get a
clean binary distribution from the source package by following the
instructions to the letter. RAT complained about a missing header on a
build related file. I know is silly but it needs fixing. Other than that
the binaries look good to me!
Cheers,
Andres
-------------------------------------------
Java Champion; Groovy Enthusiast
http://jroller.com/aalmiray
http://www.linkedin.com/in/aalmiray
--
What goes up, must come down. Ask any system administrator.
There are 10 types of people in the world: Those who understand binary, and
those who don't.
To understand recursion, we must first understand recursion.
On Mon, Jul 13, 2015 at 9:42 AM, Cédric Champeau <ce...@gmail.com>
wrote:
> Hi all!
>
> Vote for the release of Apache Groovy 2.4.4-incubating has passed with 7
> +1 votes (6 binding) and 1 (one) -1 binding vote. We will now ask the IPMC
> to vote on the release.
>
> +1 votes:
>
> IPMC:
> Emmanuel Lécharny
>
> PPMC:
> Cédric Champeau
> Guillaume Laforge
> Pascal Schumacher
> Paul King
> Jochen Theodorou
>
> Non binding:
> Steve Amerige
>
> 0 votes
>
> (none)
>
> -1 votes
> Andrés Almiray
>
> Vote thread:
> http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201507.mbox/%3CCADQzvm%3DzDNCxpOua3LQ1ZNo62Aq40QZM7SJwgER5MfkArWrTeA%40mail.gmail.com%3E
>
>