You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Reuben Kuhnert <si...@gmail.com> on 2015/05/04 15:55:28 UTC

Review Request 33806: Add Tree traversal tools to ParseUtil class that allow for checking node structures with general predicate

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33806/
-----------------------------------------------------------

Review request for hive and Sergio Pena.


Bugs: HIVE-10190
    https://issues.apache.org/jira/browse/HIVE-10190


Repository: hive-git


Description
-------

HIVE-10190: CBO: AST mode checks for TABLESAMPLE with AST.toString().contains("TOK_TABLESPLITSAMPLE")


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 7614463525262f01375c1336e89a18670862bb7d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 373429cbf666f1b19828c532aea3c07f08f95e1a 

Diff: https://reviews.apache.org/r/33806/diff/


Testing
-------

Tested locally


Thanks,

Reuben Kuhnert

Re: Review Request 33806: Add Tree traversal tools to ParseUtil class that allow for checking node structures with general predicate

Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33806/#review82383
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
<https://reviews.apache.org/r/33806/#comment133119>

    Hive uses the exact class name in the imports instead of *. 
    
    Also, seems java.util.function is a java8 functionality. I tried to compile it with java7, but it fails:
    
    [ERROR] /opt/local/hive/upstream/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:[22,26] package java.util.function does not exist
    [ERROR] /opt/local/hive/upstream/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:[234,59] cannot find symbol
      symbol:   class Predicate
      location: class org.apache.hadoop.hive.ql.parse.ParseUtils
    [ERROR] /opt/local/hive/upstream/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java:[226,53] cannot find symbol
      symbol:   class Predicate
      location: class org.apache.hadoop.hive.ql.parse.ParseUtils


- Sergio Pena


On May 4, 2015, 1:55 p.m., Reuben Kuhnert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33806/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 1:55 p.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Bugs: HIVE-10190
>     https://issues.apache.org/jira/browse/HIVE-10190
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-10190: CBO: AST mode checks for TABLESAMPLE with AST.toString().contains("TOK_TABLESPLITSAMPLE")
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 7614463525262f01375c1336e89a18670862bb7d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 373429cbf666f1b19828c532aea3c07f08f95e1a 
> 
> Diff: https://reviews.apache.org/r/33806/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Reuben Kuhnert
> 
>

Re: Review Request 33806: Add Tree traversal tools to ParseUtil class that allow for checking node structures with general predicate

Posted by Reuben Kuhnert <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33806/
-----------------------------------------------------------

(Updated May 10, 2015, 2:05 p.m.)


Review request for hive and Sergio Pena.


Changes
-------

Updated diff that is verifyably passing.


Bugs: HIVE-10190
    https://issues.apache.org/jira/browse/HIVE-10190


Repository: hive-git


Description
-------

HIVE-10190: CBO: AST mode checks for TABLESAMPLE with AST.toString().contains("TOK_TABLESPLITSAMPLE")


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 372c93d9af01608538b2e2e5a50c45188acb04f9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 373429cbf666f1b19828c532aea3c07f08f95e1a 

Diff: https://reviews.apache.org/r/33806/diff/


Testing
-------

Tested locally


Thanks,

Reuben Kuhnert

Re: Review Request 33806: Add Tree traversal tools to ParseUtil class that allow for checking node structures with general predicate

Posted by Reuben Kuhnert <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33806/
-----------------------------------------------------------

(Updated 5 4, 2015, 4:09 오후)


Review request for hive and Sergio Pena.


Changes
-------

Replaced Java 8 Predicate with org.apache.hadoop.hive.ql.exec.PTFUtils.Predicate (Java 7)


Bugs: HIVE-10190
    https://issues.apache.org/jira/browse/HIVE-10190


Repository: hive-git


Description
-------

HIVE-10190: CBO: AST mode checks for TABLESAMPLE with AST.toString().contains("TOK_TABLESPLITSAMPLE")


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 7614463525262f01375c1336e89a18670862bb7d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 373429cbf666f1b19828c532aea3c07f08f95e1a 

Diff: https://reviews.apache.org/r/33806/diff/


Testing
-------

Tested locally


Thanks,

Reuben Kuhnert