You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by combineads <gi...@git.apache.org> on 2015/12/22 04:56:37 UTC
[GitHub] tajo pull request: TAJO-1921: Hbase Storage can cause NPE when the...
GitHub user combineads opened a pull request:
https://github.com/apache/tajo/pull/918
TAJO-1921: Hbase Storage can cause NPE when the hbase cluster is restarted
It was similarly modified by referring to TableInputFormatBase#getSplits(JobContext). Cause as much as possible to follow a policy of HBase.
And then the size of memstore will not have a big impact for bigdata analysis. So it was removed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/combineads/tajo TAJO-1921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/918.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #918
----
commit d3ffcabb44539427532da20678c788e867098800
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2015-12-16T05:26:27Z
Remove unused import class
commit 31637c41cdcebbccc5854de8a131e5cd86f1c4a3
Author: combineads <co...@combineads.co.kr>
Date: 2015-12-16T05:57:01Z
Merge remote-tracking branch 'upstream/master'
commit 463dd93c0dcc0b5f022308ad2adc3da7068c4441
Author: combineads <co...@combineads.co.kr>
Date: 2015-12-18T02:35:32Z
Merge remote-tracking branch 'upstream/master'
commit f51da8eb507c3ca5745f3afd73c496a28dd7b107
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2015-12-22T03:49:09Z
TAJO-1921: Hbase Storage can cause NPE when the hbase cluster is
restarted
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1921: Hbase Storage can cause NPE when the...
Posted by combineads <gi...@git.apache.org>.
Github user combineads commented on the pull request:
https://github.com/apache/tajo/pull/918#issuecomment-169935838
I had to modify the source.
Thank you for comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1921: Hbase Storage can cause NPE when the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/918
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1921: Hbase Storage can cause NPE when the...
Posted by combineads <gi...@git.apache.org>.
Github user combineads commented on the pull request:
https://github.com/apache/tajo/pull/918#issuecomment-166500787
@hyunsik I think TAJO-1921 and TAJO-1940 seems to be a conflict. If TAJO-1940 is deployed, I can also be modified again.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1921: Hbase Storage can cause NPE when the...
Posted by combineads <gi...@git.apache.org>.
Github user combineads commented on the pull request:
https://github.com/apache/tajo/pull/918#issuecomment-171588421
@hyunsik Anything else to commit this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1921: Hbase Storage can cause NPE when the...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/918#issuecomment-169565259
I'm reviewing the patch. Your suggestion sounds good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1921: Hbase Storage can cause NPE when the...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/918#issuecomment-172994141
+1 the patch looks good to me. I'm sorry for late.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1921: Hbase Storage can cause NPE when the...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/918#issuecomment-169914203
The patch looks good to me. Here are some comments.
Our coding standard uses 2 space instead of tab. Some lines do not follow the indent of our coding standard. Please refer to https://cwiki.apache.org/confluence/display/TAJO/Code+Style.
Other parts looks good to me. Here is my +1. Could you correct line indents? Then, I'll commit it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---